fix(codex): let the 1M opt-in raise gpt-6-astra to its own ceiling - #3414
Conversation
The dashboard 1M toggle writes providerContextCaps.openai = 922000 for the whole native group, but narrowToLimits only RAISED a window for members of NATIVE_GPT56_FAMILY. Astra ships its own 272k/872k pair and was removed from that family so it would stop inheriting the measured 922k clamp, which silently took the opt-in path with it: the toggle moved every other native and left Astra pinned at 272k. Read the opt-in ceiling per slug instead. The family keeps its measured 922k; a self-described native uses its own maxContextWindow, so the shared 922k lever raises Astra to 872k rather than advertising a ceiling the model does not have. Verified live: with the toggle on, /v1/models reports 922000 for gpt-5.6-sol and 872000 for gpt-6-astra.
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe catalog now resolves long-window opt-in ceilings per model slug. GPT-5.6 family models retain the 922k ceiling. Models such as ChangesNative context ceiling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The 1M opt-in now raises gpt-6-astra to its configured 872k context ceiling while retaining GPT-5.6 behavior. The change includes focused regression coverage, with no current merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 75 / 80이 PR은 대시보드의 네이티브 1M(긴 창) 켜기 스위치가 고치는 방식은 단순하다. 패밀리 소속 여부가 아니라 슬러그마다 opt-in 천장을 읽는다. 새 이게 #3410(목록 해제) → #3412(업스트림 스키마 정렬) 다음 자연스러운 한 칸이다. #3412가 “Astra는 Sol이 아니다”를 숫자·스키마로 고정한 뒤, 이번 PR은 그 독립 숫자 쌍에 1M 토글이 다시 붙게 만든다. types.ts/config.ts 분할과 무관하고, 손댄 파일도
src/codex/catalog/metadata.ts NativeContextLimits JSDoc - 아직도 GPT-5.6 패밀리만 올리고 다른 네이티브는 내리기만 한다고 쓰여 있다. 이번 변경 뒤에는 Astra처럼 maxContextWindow > contextWindow 인 자기 서술 네이티브도 올릴 수 있으므로 주석이 코드와 어긋난다. 같은 파일에서 같이 고치면 이후 기여자가 또 패밀리 게이트로 돌아갈 위험이 줄어든다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Summary
The dashboard's native 1M opt-in had no effect on
gpt-6-astra: the toggle raised every other native model's window and left Astra pinned at 272k.The toggle writes
providerContextCaps.openai = 922_000for the whole native group.narrowToLimitsonly ever raised a window for members ofNATIVE_GPT56_FAMILY— for everything else a cap can only narrow. Astra was removed from that family so it would stop inheriting the measured 922k clamp (its real ceiling is 872k), and that removal silently took the opt-in path with it.The fix reads the opt-in ceiling per slug rather than keying it on family membership. The GPT-5.6 family keeps its measured 922k; a self-described native uses its own
maxContextWindow. So the shared 922k lever raises Astra to 872k — its actual ceiling — instead of advertising a window the model does not have.Verification
providerContextCaps.openai = 922000),/v1/modelsreports922000forgpt-5.6-soland872000forgpt-6-astra. Before the fix Astra reported272000.gpt-6-astrawritescontext_window: 872000.{272000, 872000}.bun teston the catalog, toggle and desktop-context suites — 306 pass / 0 fail.bun run test:changed— 10430 pass / 0 fail across 556 files.bun run typecheck— exit 0.No GUI change: the toggle already sent the right lever, the server-side resolver ignored it.
Checklist
Summary by CodeRabbit
Improvements
Bug Fixes
gpt-6-astra, increasing its opt-in limit to 872,000 tokens rather than applying an unrelated 922,000-token ceiling.