feat(gui): Models catalog — one advanced disclosure, provider ⋯, v2 switch moves to Subagents - #3390
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (17)
📝 WalkthroughWalkthroughThe Models page moves multi-agent mode selection to Subagent delegation. It groups catalog controls into native disclosures, replaces restart and inline hints with tooltips, updates related tests, and adds localized accessibility strings. ChangesModels controls
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant SubagentDelegationSection
participant onUltraModeSave
participant V2API
User->>SubagentDelegationSection: Select v1, default, or v2
SubagentDelegationSection->>onUltraModeSave: Submit multiAgentMode patch
onUltraModeSave->>V2API: PUT /api/v2
V2API-->>onUltraModeSave: Persist selected mode
onUltraModeSave->>V2API: Re-read multiAgentMode
V2API-->>SubagentDelegationSection: Return server state
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ch moves to Subagents The catalog opened with a four-line explanation, a wall of catalog-wide switches (new-model policy, aliases, shadow-call, the v1/base/v2 surface switch, context cap + its paragraph), an order-hint paragraph, and six controls repeated in every provider header. Now: - The explanation and the order hint are focusable info tooltips (visible on focus, named for assistive tech); combos/routing subtitles show only while their workspace is empty. - Catalog-wide policy sits behind one closed "고급" details. - Each provider header keeps edit + 모두 켜기/끄기 inline; aliases, custom model, presets and the context cap fold into a labelled ⋯ details (inline reveal, DOM tab order — a disclosure, not a menu). - The v1/base/v2 switch is a delegation setting; it moves to the Subagents delegation section, which already owned the /api/v2 read and write (UltraModePatch gains multiAgentMode). Models keeps its v2 state for keep-native and thread controls. - The page-head Codex-restart orb (third copy; sidebar orb + banner remain) is gone. Plan: devlog/_plan/260904_dashboard_minimal/030_models_catalog.md.
…server on re-read
d58222b to
5404ae0
Compare
리뷰 · 우선순위 72 / 80이 PR은 대시보드 미니멀 로드맵의 3단계입니다. 계획 문서는 변경 뒤에는 카탈로그용 긴 설명과 피커 순서 안내가 포커스 가능한 ⓘ Tooltip으로 줄고, 카탈로그 전역 정책은 닫힌 테스트도 이 축을 맞춥니다. 새
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d58222bd48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Tooltip content={t("models.subtitle")} side="bottom" maxWidth={420}> | ||
| <IconInfo width={14} height={14} aria-hidden="true" /> | ||
| <span className="sr-only">{t("models.subtitleAria")}</span> | ||
| </Tooltip> |
There was a problem hiding this comment.
When the user selects Combos, Routing, or Compatibility, this tooltip remains visible because it is rendered unconditionally in the shared page header, but both its accessible name and content describe only the model catalog. This is especially misleading for nonempty Combos and Routing workspaces, where line 2190 also removes the tab-specific subtitle, leaving the catalog explanation as the only visible help affordance. Render this tooltip only when tab === "catalog", or change it to use help content for the active tab.
Useful? React with 👍 / 👎.
…psed The 260904 dashboard-minimal roadmap traded working controls for visual quiet, and the result cost real function. Reverts lidge-jun#3382 (sidebar footer), lidge-jun#3387 (dashboard home), lidge-jun#3390 (models catalog), lidge-jun#3395 (usage) and lidge-jun#3399 (the i18n prune that removed those surfaces keys). What comes back: the labelled sidebar footer rows instead of two rows of unlabelled 28px orbs; the v1/base/v2 subagent surface switch inline on Models, which is a primary control and not an advanced disclosure; the ultra-mode effort controls; the sidecar and memory cards without their closed disclosure; and the Usage active-days card with its heatmap inline rather than behind a 일별 활동 details. The v1/base/v2 switch is kept in BOTH homes: the revert restores Models, and UltraModeState/UltraModePatch keep multiAgentMode so the Subagents copy added by lidge-jun#3390 still reads and writes /api/v2. Three imports the revert left dangling (Tooltip, IconInfo, TKey) are restored alongside it. dashboard-tabs.test.ts anchored its .page-tabs CSS lookup on a bare substring, which now matches an earlier descendant rule added after it was written; it reads the base rule at line start instead.
1 participant
Summary
Phase 3 of the dashboard-minimal roadmap (
devlog/_plan/260904_dashboard_minimal/030_models_catalog.md). The Models catalog opened with a four-line explanation, a wall of catalog-wide switches (new-model policy, aliases, shadow-call intercept, the v1/base/v2 surface switch, context cap plus its paragraph), an order-hint paragraph, and six controls repeated in every provider header — 135 interactive controls before a single model row.<details>; every control is still there, one click away.<details>(inline reveal, DOM tab order — a disclosure, not a menu role)./api/v2read and write (UltraModePatchgains an optionalmultiAgentMode). Models keeps its v2 state for the keep-native and thread controls.Verification
Focused checks only (repository-wide local suite intentionally not run; hosted CI on this head is the broad gate):
New:
models-advanced-disclosure.test.ts(details placement, switch relocated to Subagents with the/api/v2patch, tooltips named, head has no restart, provider ⋯ contents, CSS markers). Updated:codex-stale-banner,models-keep-native-v1-placement.Render-grounded (Vite dev build read-only against a running proxy, ko, 1440 px).
#models: 고급 closed, 8 provider ⋯ disclosures closed, no head orb, no subtitle paragraph, no order-hint paragraph, no v1/base/v2 radiogroup; opening 고급 reveals 8 controls and opening a provider's ⋯ reveals 기본 별칭 사용 / 커스텀 모델 추가 / 기본 창 · 상한 / 사용자 지정 창.#subagentsrenders the 서브에이전트 radiogroup reading the livev1.Checklist
Summary by CodeRabbit
v1,default, orv2) to the Subagents workspace, with saved settings and loading-state protection.