feat(gui): expose sub-agent fallback settings - #3252
Conversation
|
This follow-up is the GUI half split from closed PR #3228. The runtime auto-native fallback remains reverted per #3242; this PR only exposes the existing The branch is based on the current |
|
⏳ DRAFT
What to do
Review readiness checklist
2/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 47 / 80이 PR은 서브에이전트 폴백 체인을 대시보드에서 편집하게 하고, 암호화 V2 네이티브 전용 경로에서 추천 로스터( 구성은 세 층이다. (1) GUI: 보안 방향은 HEAD의 #3242 결정과 맞다. 네이티브 ChatGPT 자격 증명을 쓰는 모델을 조용히 폴백에 넣지 않고, 대시보드에서 명시로 켠 때만 로스터를 쓴다. 로스터가 비어 있으면 합성 폴백을 만들지 않는다. 테스트도 스위치 on/off/unset 경로를 점수가 낮은 이유다. 첫째, 기능 자체는 암호화 V2 복구 열차의 자연스러운 후속이다. 다만 ‘지금 바로 넣어야 하는 작은 구멍’보다는 ‘옵트인 GUI + 설정 키’에 가깝다. 중복 원본(#3253)은 이미 닫혔고 이 PR이 통합본이므로 닫지 말고 다듬는 쪽이 맞다.
메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Implemented and pushed in 914aaaf.
Validation: typecheck, GUI build, focused GUI test (prior run), and diff check passed. The remaining local limitation is the known Windows Bun user-lock/atomic-write ENOENT race; CI checks currently pass. |
|
Polished the fallback-chain editor in a7f7ddb: compact icon-only reorder/remove actions, improved spacing for the interval/toggle/save controls, and responsive stacking for narrow dashboard widths. Refreshed screenshot: docs-site/public/pr-screenshots/subagent-fallback-settings-v2.png. |
Summary
Expose and improve sub-agent fallback settings in the dashboard, and add an explicit switch that makes the fallback chain use the configured
subagentModelsroster.subagentModelFallback, availability polling interval, and save state via/api/subagent-model-fallback.subagentModelFallbackUseSubagentModels. When enabled for spawned sub-agents,subagentModelsis the complete ordered fallback list; global, per-model, and legacy TOML fallback entries are ignored. An unset or empty roster produces no fallback.GET/PUT /api/subagent-model-fallbackpersists the boolean, with focused runtime/API/GUI coverage and updated configuration guidance.Difference between the two lists
subagentModelsis the featured ordered roster shown in the sub-agent picker.subagentModelFallbackis the separately configured failover chain. With the switch enabled, the roster becomes the complete fallback chain for spawned sub-agents and the separate fallback settings are ignored.Verification
bun run typecheck— passbun run buildfromgui— passbun test ./gui/tests/subagents-fallback.test.ts --max-concurrency=1— passed during focused validation; a later rerun was blocked by Bun's existing Windows user-lock contentiongit diff --check— passENOENTrace.UI screenshot
The Subagents dashboard now shows the fallback chain as readable stacked rows with separate controls, an add-model row, polling interval, roster-reuse switch, and save action:
Checklist
src/andgui/src/have focused regression tests.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met: