You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@murrant I've carried your fix for preserving the original REMOTE_ADDR and REMOTE_PORT into #608. I also made Nginx derive its logging trust rules from LibreNMS's cached configuration, so setting APP_TRUSTED_PROXIES handles both HTTPS detection and client-IP logging. REAL_IP_FROM remains available as an explicit logging override.
I reverted the fixed Traefik network/subnet introduced by #569 since that shouldn't dictate the network layout of a deployment. PHP-FPM keeps CLEAR_ENV=yes, with the trusted-proxy settings supplied through Laravel's configuration cache.
I added integration coverage for trusted and untrusted requests, proxy chains, wildcard settings, and the legacy defaults. That also caught a difference in wildcard handling between their Laravel versions, which Nginx now follows.
Could you take a look? I'd like to consolidate the fix in #608 and supersede this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #590