Skip to content

Pass through ip info to LibreNMS correctly - #591

Closed
murrant wants to merge 1 commit into
librenms:masterfrom
murrant:fix/realip-remote-addr
Closed

murrant wants to merge 1 commit into
librenms:masterfrom
murrant:fix/realip-remote-addr

Conversation

@murrant

@murrant murrant commented Oct 2, 2026

Copy link
Copy Markdown
Member

fixes #590

@crazy-max

Copy link
Copy Markdown
Member

@murrant I've carried your fix for preserving the original REMOTE_ADDR and REMOTE_PORT into #608. I also made Nginx derive its logging trust rules from LibreNMS's cached configuration, so setting APP_TRUSTED_PROXIES handles both HTTPS detection and client-IP logging. REAL_IP_FROM remains available as an explicit logging override.

I reverted the fixed Traefik network/subnet introduced by #569 since that shouldn't dictate the network layout of a deployment. PHP-FPM keeps CLEAR_ENV=yes, with the trusted-proxy settings supplied through Laravel's configuration cache.

I added integration coverage for trusted and untrusted requests, proxy chains, wildcard settings, and the legacy defaults. That also caught a difference in wildcard handling between their Laravel versions, which Nginx now follows.

Could you take a look? I'd like to consolidate the fix in #608 and supersede this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect protocol sent over reverse proxy

2 participants