Repository navigation
deb: build the package from debian/ with build-deb-action - #123
Merged
everoddandeven merged 1 commit intoOct 30, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
everoddandeven
force-pushed
the
ci/build-deb-action
branch
3 times, most recently
from
October 30, 2026 07:34
412989a to
e2ea136
Compare
debian/ becomes a Debian source package: the Build-Depends in control, a rules file with dh, a changelog and source/format. jtdor/build-deb-action installs the Build-Depends in a container of each release and runs dpkg-buildpackage. That replaces Dockerfile.linux, docker/build.sh and the buildx, cache and retry steps of the workflow, and dh computes the dependencies of the package, so nothing patches the control file or runs dpkg-shlibdeps by hand any more. debian/changelog does not repeat the version: debian/set-version.sh adds the entry for the version of pyproject.toml and the release, and the package is still named python3-monero_0.9.10-1noble1_amd64.deb. bin/build_monero_cpp.sh builds monero-project and monero-cpp, and debian/install-static-deps.sh the static expat and unbound, as the Dockerfile did. The flags of dpkg-buildflags are not passed to them. The packages are built on: - pull requests: amd64 on trixie and bookworm. - main: also amd64 on noble and jammy, and arm64 on trixie and bookworm. - tags and manual runs with full: the three architectures on the four releases. release.yml checks the tag and the runs of main that it needs first, then calls build-deb.yml and takes the packages from its own run, so a missing run does not show up after the hours of the build. arm64 and armhf are built natively on ubuntu-24.04-arm runners, which run 32 bit arm containers, instead of under qemu, where they took 76 to 136 minutes against 10 to 14 for amd64. A 32 bit container on a 64 bit arm kernel reports aarch64, which build_monero_cpp.sh would take for a 64 bit build and the configure scripts for the host, so debian/rules runs the steps of the build under linux32 there and the script knows armv7l and armv8l. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
everoddandeven
force-pushed
the
ci/build-deb-action
branch
from
October 30, 2026 07:36
e2ea136 to
5e8bdf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debian/ becomes a Debian source package: the Build-Depends in control, a rules file with dh, a changelog and source/format. jtdor/build-deb-action installs the Build-Depends in a container of each release and runs dpkg-buildpackage. That replaces Dockerfile.linux, docker/build.sh and the buildx, cache and retry steps of the workflow, and dh computes the dependencies of the package, so nothing patches the control file or runs dpkg-shlibdeps by hand any more.
debian/changelog does not repeat the version: debian/set-version.sh adds the entry for the version of pyproject.toml and the release, and the package is still named python3-monero_0.9.10-1noble1_amd64.deb.
bin/build_monero_cpp.sh builds monero-project and monero-cpp, and debian/install-static-deps.sh the static expat and unbound, as the Dockerfile did. The flags of dpkg-buildflags are not passed to them.