Repository navigation
Conversation
Exercise binomial, negative-binomial, hypergeometric, and Poisson distributions at the same inputs for float, double, real, and Fp!64. Cover PMFs, log-PMFs, tails, and inverse CDFs across the scalar and checked APIs. Include exact cumulative-boundary queries for binomial and negative-binomial inverses, and independently rounded Fp tail references for hypergeometric and Poisson. Require successful checked statuses before inspecting results. Keep these small cases in the ordinary test suite to complement the existing precision-specific and slow-numerics tests. AI-Assisted-By: Codex (GPT-6 Astra Medium)
jmh530
force-pushed
the
codex/discrete-shared-cases
branch
from
November 16, 2026 21:22
b863f9f to
f9cb244
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add shared numerical cases for binomial, negative-binomial, hypergeometric, and Poisson distributions, exercising float, double, real, and Fp!64 at the same inputs. This advances the discrete test-parity review for #157 without changing production behavior.
The tests cover PMFs, log-PMFs, scalar and checked tails, and inverse CDFs. Binomial and negative-binomial cases include exactly represented cumulative-boundary queries. Hypergeometric and Poisson checked tails use independently rounded Fp references, and checked results must report success before their values are inspected.
These small cases run in the ordinary test suite and complement existing precision-specific and slow-numerics coverage. They do not establish unrestricted checked ranges or full-precision accuracy for every type.
Validation:
AI-Assisted-By: Codex (GPT-6 Astra Medium)