Skip to content

Pack settings envelope at store creation. #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Aug 25, 2026
Merged

Pack settings envelope at store creation. #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd7a67e
Pack settings envelope at store creation.
evoskuil Aug 25, 2026
a206ae8
Add REQUIRE_NO_THROW_FALSE() and fix test.
evoskuil Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions console/executor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ std::optional<std::thread> executor::poller_thread_{};
executor& executor::factory(parser& metadata, std::istream& input,
std::ostream& output, std::ostream& error)
{
// TODO: expose fork_flags() mapping from system static chain_state method.
////metadata.configured.database.fork_flags =
//// metadata.configured.bitcoin.fork_flags();
// Pack creation settings, stored at store create and read at load.
metadata.configured.database.envelope = database::envelope{
metadata.configured.bitcoin, metadata.configured.database };

// Suppress configured batch cache sizing when batching cannot run.
if (!system::batched::accelerated())
Expand Down
2 changes: 1 addition & 1 deletion test/protocols/bitcoind/bitcoind_rpc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,7 @@ BOOST_AUTO_TEST_CASE(bitcoind_rpc__scantxoutset__status__null)
BOOST_AUTO_TEST_CASE(bitcoind_rpc__scantxoutset__abort__false)
{
const auto response = rpc("scantxoutset", "[\"abort\"]");
REQUIRE_NO_THROW_TRUE(!response.at("result").as_bool());
REQUIRE_NO_THROW_FALSE(response.at("result").as_bool());
}

BOOST_AUTO_TEST_CASE(bitcoind_rpc__scantxoutset__empty_scanobjects__invalid)
Expand Down
4 changes: 4 additions & 0 deletions test/test.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
BOOST_REQUIRE_NO_THROW(expression); \
BOOST_REQUIRE(expression)

#define REQUIRE_NO_THROW_FALSE(expression) \
BOOST_REQUIRE_NO_THROW(expression); \
BOOST_REQUIRE(!expression)

#define TEST_NAME \
boost::unit_test::framework::current_test_case().p_name.get()
#define SUITE_NAME \
Expand Down
Loading