Apply the template's own security advice to this repository - #35
Merged
Conversation
OpenSSF Scorecard raised six findings against this repository. Two were real, and both were the same mistake: the template hands generated projects a security policy and a CodeQL workflow, while the repository that ships them had neither. - SECURITY.md now exists here, scoped to the template: a bad default or an over-permissioned workflow here propagates into every project generated from it. - CodeQL runs against this repository, matching what generated projects get. Also bump the uv_build floor in the generated pyproject to match the bump Dependabot made to this repository's own. The remaining Scorecard findings are not addressed on purpose: Code-Review cannot be satisfied by a sole maintainer approving their own pull requests, Fuzzing does not apply to a project template with no parsing surface, and CII-Best-Practices requires registering with an external programme. A new test asserts this repository keeps the files and workflows it generates, including that some job still produces the "CI" status check that branch protection requires.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSSF Scorecard raised six findings against this repository. Two were real, and both were the same mistake: the template hands generated projects a security policy and a CodeQL workflow, while the repository that ships them had neither.
Fixed
Security-PolicySECURITY.mdadded, scoped to the template — a bad default here propagates into every generated projectSASTNot fixed, on purpose
Code-Review(high)FuzzingCII-Best-PracticesCI-TestsAlso
uv_buildfloor in the generatedpyproject.tomlto match the bump Dependabot made to this repository's own, so the two do not drift.CIstatus check that branch protection requires, since losing that name blocks every future merge.