Repository navigation
Update dns-persist-01 impl to draft-ietf-acme-dns-persist-02 - #566
Open
orangepizza wants to merge 4 commits into
Open
orangepizza wants to merge 4 commits into
orangepizza wants to merge 4 commits into
Conversation
use calculate account hash format, as defined in draft-ietf-acme-dns-persist-02 , instead of using accounturi as is.
orangepizza
force-pushed
the
persist-draft-02
branch
from
October 14, 2026 08:16
016be57 to
df066f8
Compare
This was referenced Oct 17, 2026
inahga
self-requested a review
November 2, 2026 21:48
inahga
reviewed
Nov 4, 2026
inahga
left a comment
Contributor
There was a problem hiding this comment.
Thanks for putting this together!
orangepizza
force-pushed
the
persist-draft-02
branch
from
November 4, 2026 02:12
c99af3c to
cc15659
Compare
Contributor
|
I spent a little bit of time with Posh-ACME since it has draft-02 support, and looks like your changeset mostly works (or, at least, interops with posh-acme 😄) However we are missing this change https://www.ietf.org/archive/id/draft-ietf-acme-dns-persist-02.html#appendix-B.1-1.12.1
That should be a one line change in struct common.Challenge. |
draft-02 changed it's name to camelCase, singular is still issuer-domain-name is that draft
inahga
previously approved these changes
Nov 5, 2026
mostly adding support for client asking ancestorDomain to validate subdomain by record at parent domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use calculate account hash format, as defined in draft-ietf-acme-dns-persist-02, instead of using accounturi as is.
while this draft requires CA to keep old key for validate old accountURI made with old key, but didn't implemented here.
Personally I think that's not something client should test for
this draft's txt record is constructed as
"; accounturi= //base64url(Hash(length_of_domain || domain_name || key || account_URL))"