Skip to content

Update dns-persist-01 impl to draft-ietf-acme-dns-persist-02 - #566

Open
orangepizza wants to merge 4 commits into
letsencrypt:mainfrom
orangepizza:persist-draft-02
Open

orangepizza wants to merge 4 commits into
letsencrypt:mainfrom
orangepizza:persist-draft-02

Conversation

@orangepizza

Copy link
Copy Markdown
Contributor

use calculate account hash format, as defined in draft-ietf-acme-dns-persist-02, instead of using accounturi as is.
while this draft requires CA to keep old key for validate old accountURI made with old key, but didn't implemented here.
Personally I think that's not something client should test for

this draft's txt record is constructed as
"; accounturi= //base64url(Hash(length_of_domain || domain_name || key || account_URL))"

use calculate account hash format, as defined in draft-ietf-acme-dns-persist-02 , instead of using accounturi as is.

@inahga inahga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

Comment thread va/va_test.go Resolved
Comment thread cmd/pebble/main.go Resolved
Comment thread va/va.go Resolved
Comment thread va/va.go Resolved
Comment thread va/va.go Resolved
Comment thread va/va.go Resolved
Comment thread va/va.go Resolved
Comment thread va/va_test.go Resolved
Comment thread va/va.go Resolved
@inahga

inahga commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

I spent a little bit of time with Posh-ACME since it has draft-02 support, and looks like your changeset mostly works (or, at least, interops with posh-acme 😄)

However we are missing this change https://www.ietf.org/archive/id/draft-ietf-acme-dns-persist-02.html#appendix-B.1-1.12.1

Renamed the challenge object's plural field from issuer-domain-names to issuerDomainNames to align with ACME's camelCase convention ([RFC8555]); the singular DNS issuer-domain-name parameter and persistUntil are unchanged (#56).

That should be a one line change in struct common.Challenge.

draft-02 changed it's name to camelCase, singular is still issuer-domain-name is that draft
inahga
inahga previously approved these changes Nov 5, 2026
mostly adding support for client asking ancestorDomain to validate subdomain by record at parent domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants