Skip to content

Add ML-DSA support - #1

Closed
inahga wants to merge 2 commits into
mainfrom
inahga/mldsa
Closed

inahga wants to merge 2 commits into
mainfrom
inahga/mldsa

Conversation

@inahga

@inahga inahga commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Allow ML-DSA for account keys and certificates.

I allowed all parameter sets to be consistent with lego's trend of being somewhat exhaustive, e.g. allowing RSA 8192 and 3072 keys. Hopefully that will make this a eminently upstreamable patch, once lego updates to Go 1.27.

This is sufficient for lego to acquire a certificate from main branch of Pebble and Cactus.

@inahga

inahga commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

Note: golangci-lint is upset because there are new go 1.27 lints. I will leave those unresolved.

@aarongable aarongable left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this even more upstreamable, you could put the ML-DSA code in files marked with //go:build go1.27. This is the approach taken in our PR to add ML-DSA support to eggsampler/acme. Then lego wouldn't have to bump its go.mod version and drop support for go1.26 in order to take the patch.

@inahga

inahga commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator Author

I had figured I’d just sit on this patch until they go to 1.27 of their own volition. They seem to follow Go’s policy around supporting the two latest Go versions, so we’d just wait for 1.28.

If I were the maintainer I would be a little bit nervous about sprinkling built tags around, but perhaps I’m overthinking it.

@inahga

inahga commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Convinced over slack to give the build tag approach a try. It's indeed not too bad.

@inahga inahga closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants