Remove sa.FQDNSetExists dead code - #8888
Open
ezekiel wants to merge 3 commits into
Open
Conversation
aarongable
reviewed
Jul 20, 2026
Contributor
There was a problem hiding this comment.
This helper function is still used, but now used only by sa.AddPrecertificate. It should move closer to its calling code (or be inlined there).
…texists-dead Discarded local generated code to resolve conflicts, as it will just be regenerated for next commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing is using this SA gRPC. The SA itself has an instance of directly using
checkFQDNSetExists.