Skip to content

Answer a question whose comment lost the agent's marker line - #54

Merged
Param-Harrison merged 1 commit into
mainfrom
fix/question-marker
Oct 12, 2026
Merged

Param-Harrison merged 1 commit into
mainfrom
fix/question-marker

Conversation

@Param-Harrison

Copy link
Copy Markdown
Contributor

A card sat in needs-info and ignored the operator's answer.

The build agent wrote its question without the <!-- factory:question v1 --> line the skill asks for. findQuestionComment matched only that line, so resumeNeedsInfo found no question and the card could never resume. The runner always adds its own factory:data marker with "stage":"question" to that comment, so the reader now accepts either one.

  • Test: tests/scenarios.test.ts "8b. a question the agent wrote without its marker line still takes an answer" (fails before the fix: waiting instead of shipped).
  • Mutation: "watch: the runner's question marker opens a question" in tests/mutations.json. Removing the new condition turns the test red (checked by hand).
  • make check: 1724 pass, 0 fail.

Based on release/v4.0, so until #40 merges the diff also shows the release. Once #40 lands it shrinks to this one commit.

🤖 Generated with Claude Code

The build agent on a real card wrote question-comment.md without the
<!-- factory:question v1 --> line. findQuestionComment matched only that
line, so the card sat in needs-info and ignored the operator's answer.
The runner always adds its own factory:data marker with stage question,
so the reader now accepts that one too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Param-Harrison
Param-Harrison merged commit cccc61b into main Oct 12, 2026
3 checks passed
@Param-Harrison
Param-Harrison deleted the fix/question-marker branch October 12, 2026 05:23
@Param-Harrison Param-Harrison mentioned this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant