Repository navigation
[QTI] A QTI item with a comment quoting its root tag is published without the node's language #6235
Description
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Target branch: unstable
Observed behavior
set_qti_item_language(utils/assessment/qti/media.py) rewrites the first<qti-assessment-item …>match in the raw text.- A comment before the root that quotes that tag takes the match.
xml:langis written inside the comment; the real root keeps its own language.- The item passes
validate_qti_item.
Steps to reproduce
- Insert
<!-- <qti-assessment-item foo="1"> -->before the root ofVALID_CHOICE_ITEM(tests/utils/qti/test_validation.py). - Call
set_qti_item_language(xml, "fr"). - The real root still has
xml:lang="en-US".
Acceptance Criteria
-
set_qti_item_languagesets the language on the real root regardless of comments before it. - A test covers a comment quoting the root start tag.
Activity
rtibblesbot commentedon Sep 30, 2026
Plan:
set_qti_item_languagestampsxml:langon the real<qti-assessment-item>root even when a comment (or other prolog markup) quotes that start tag before it.Assumptions — the issue did not settle these; say so if one is wrong.
>inside a root attribute value still ends the tag match early ([^>]*); not in scope, and serializers escape it as>. If items carry a raw>,xml:langlands mid-value.raw_dataunchanged, as today; if a caller expects an error, it needs a separate change.@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
fix: parse QTI items to rewrite them at publish instead of matching r…