You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ask for the issue first in the unlinked pull request message #112
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Overview
The message sent when a pull request links no issue asks the contributor to link one. It does not
say that the issue is meant to come first.
That message is read at the one moment the order matters, so it is the cheapest place to teach it.
Complexity: Low Target branch: main
Context
BOT_MESSAGE_LINK_ISSUE in scripts/constants.js, added in #103, reads:
📎 We couldn't find an issue linked to this pull request. Please edit the description and link
one under References, for example Fixes #123 or Closes #123. A plain #123 mention doesn't
link the PR to the issue.
It works as far as it goes. In learningequality/kolibri#15539 the author read it and opened an issue
to link. What it does not say is that next time the issue comes first.
The Change
Add one sentence asking for the issue first in future, pointing at the contributing guidelines.
The wording has to match whatever the guidelines end up saying, so this follows the page update.
Out of Scope
Closing a pull request that links no issue.
Changing when the message is sent, or the three cases in contributor-pr-reply.
Acceptance Criteria
The message asks for the issue first in future, and links the contributing guidelines.
The wording agrees with the contributing page.
The existing test that asserts the prompt still passes.
Testing
Covered by scripts/contributor-pr-reply.test.js. The case for an unlinked pull request asserts
that the prompt is appended, and the case for a linked one asserts that it is not.
Activity