Repository navigation
⚡ Build each transliteration table once instead of on every call - #1110
Merged
Merged
Conversation
Every call rebuilt the lookup table by spreading an object per letter, about 1.8 ms per call since the Grantha rows were added. The tables are now built once per notation and Grantha setting: about 1 µs per call.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transliteraterebuilt its lookup table on every call, spreading the object once per letter, so the cost grew with the square of the table. With 0.9.0's 78 Grantha rows, a call takes about twice as long as before. Measured with 20,000 calls ofgetRomanization('பாடசாலைக்கு'):This showed up on learn-tamil.com: a unit test that builds a 1,000-word dictionary passed the 5-second limit after upgrading to 0.9.0, and every page build calls these functions many times.
Change
The table is built once per notation and Grantha setting, and then reused. Output is unchanged. A new test switches between
{ grantha: false }and the default to check the cached tables stay apart.Output doesn't change, so I'd release this as 0.9.1 (patch).
Checks
pnpm test(9 passed, snapshots unchanged),pnpm eslint,pnpm tsc --noEmitandpnpm format --checkall pass.