Skip to content

docs(search): say why a lookup’s local copy stays opt-in - #1098

Open
ddeboer wants to merge 1 commit into
mainfrom
docs/search-local-stays-opt-in
Open

ddeboer wants to merge 1 commit into
mainfrom
docs/search-local-stays-opt-in

Conversation

@ddeboer

@ddeboer ddeboer commented Nov 16, 2026

Copy link
Copy Markdown
Member

Fix #818

Keeps the local flag. #818 had narrowed to one question: does any deployment keep a lookup plain on purpose? Three of them do, and two kinds of lookup couldn’t store a copy even if the flag went.

  • Literal lookups. LOL’s CreativeWork.temporalCoverage is a literal: 'period' lookup. It stores period strings beside referents in one list, and literal-with-local refuses a nested copy there. Dropping the flag would mean redesigning that storage, not deleting a flag.
  • Derived and from lookups. LOL’s provenance dataset, CreativeWork.publisher and CreativeWork.isPartOf get their ids from a derive or from the run’s context, so no referent node sits behind them. A probe declaring local: true on a derived lookup still projected a bare id.
  • Targets built from the same graph. In the Dataset Register, publisher (Organization) and terminology_source (TerminologySource) resolve against documents built from the same registration graph as the dataset that refers to them. Its comments make query-time resolution the design (ADR 0008), so a stored copy would hold each of those documents twice.

Nothing the flag still refuses is in use either. No field in LOL, the Dataset Register or Collectie Zeeland declares joinable, and #993 already gave LOL the facet it needed. The only fields that opt in today are six in LOL and one in Collectie Zeeland.

The change is a paragraph on ReferenceStrategy.local that names these cases, so the next person to ask why it’s opt-in finds the answer there.

- Derived and from lookups yield bare ids, with no referent node to copy
- Literal lookups store strings beside their referents, which a nested copy cannot sit beside
- A target built from the referring document’s own graph would only be stored twice

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

search: drop the local flag – every lookup stores the referring document’s copy of the referent

1 participant