Repository navigation
Conversation
- Derived and from lookups yield bare ids, with no referent node to copy - Literal lookups store strings beside their referents, which a nested copy cannot sit beside - A target built from the referring document’s own graph would only be stored twice
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #818
Keeps the
localflag. #818 had narrowed to one question: does any deployment keep a lookup plain on purpose? Three of them do, and two kinds of lookup couldn’t store a copy even if the flag went.CreativeWork.temporalCoverageis aliteral: 'period'lookup. It stores period strings beside referents in one list, andliteral-with-localrefuses a nested copy there. Dropping the flag would mean redesigning that storage, not deleting a flag.fromlookups. LOL’s provenancedataset,CreativeWork.publisherandCreativeWork.isPartOfget their ids from aderiveor from the run’s context, so no referent node sits behind them. A probe declaringlocal: trueon a derived lookup still projected a bare id.publisher(Organization) andterminology_source(TerminologySource) resolve against documents built from the same registration graph as the dataset that refers to them. Its comments make query-time resolution the design (ADR 0008), so a stored copy would hold each of those documents twice.Nothing the flag still refuses is in use either. No field in LOL, the Dataset Register or Collectie Zeeland declares
joinable, and #993 already gave LOL the facet it needed. The only fields that opt in today are six in LOL and one in Collectie Zeeland.The change is a paragraph on
ReferenceStrategy.localthat names these cases, so the next person to ask why it’s opt-in finds the answer there.