docs(kanvas): refresh the validation screenshots to current chrome - #1256
Conversation
Both figures on validating-designs were captured in the older light theme and no longer match Kanvas. Replace them with captures of the current Validate design modal: - successful-validation.png: a clean run, reporting the components and annotations checked and 0 errors. - validation-error.png: a failing run with the component's row expanded, showing its three field-level messages. The example error in the text named a field the old screenshot showed, so it now describes the error in the new one and mentions that the row has to be expanded to see the messages. Signed-off-by: hiyach28 <hiyach28@gmail.com>
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for PR #1256 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
|
Muse Code review: screenshot refresh is genuine and still needed. Verified on master vs this branch:
Findings (all non-blocking):
Also verified no conflict with the troubleshooting steps just below ( |
Fixes #1268
Both figures on
kanvas/tasks/designs/validating-designswere captured in the older light theme and no longer match what Kanvas shows. Replaced with fresh captures of the current Validate design modal, cropped to the modal edges.successful-validation.pngvalidation-error.pngFilenames are unchanged, so no references move.
Text change
The "Missing Required Field" example named the exact field the old screenshot happened to show (
.spec.template.spec.containers.0.env.0). The new capture shows a different component, so the sentence now describes that one, and mentions that a component's row has to be expanded before its messages appear, which the modal does not do by default.Notes