[Docs] Fix floating Kanvas card overlapping navbar (#1187) - #1190
dineshmanideep wants to merge 1 commit into
Conversation
Signed-off-by: Paluvadi Dinesh Manideep <dineshmanideep@gmail.com>
📝 WalkthroughWalkthroughThe Kanvas corner popup now uses viewport-aware spacing and dimensions. Its inner content scrolls within bounded heights. Links and buttons prevent horizontal overflow on narrow layouts. ChangesKanvas popup layout
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/scss/_kanvas-corner-popup.scss`:
- Around line 16-19: In the custom property block, add an empty line after
--kanvas-navbar-height and before the position declaration to satisfy
Stylelint’s declaration-empty-line-before rule.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 510c8874-452c-46fd-8279-6757aebff06b
📒 Files selected for processing (1)
assets/scss/_kanvas-corner-popup.scss
| --kanvas-top-gap:1rem; | ||
| --kanvas-bottom-gap: 3rem; | ||
| --kanvas-navbar-height: 6rem; | ||
| position: fixed; |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the Stylelint error before merge.
Add an empty line between the custom property declarations and position. Stylelint reports declaration-empty-line-before on Line 19.
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 19-19: Expected empty line before declaration (declaration-empty-line-before)
(declaration-empty-line-before)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/scss/_kanvas-corner-popup.scss` around lines 16 - 19, In the custom
property block, add an empty line after --kanvas-navbar-height and before the
position declaration to satisfy Stylelint’s declaration-empty-line-before rule.
Source: Linters/SAST tools
Sbragul26
left a comment
There was a problem hiding this comment.
@dineshmanideep, please address the CodeRabbit comment.
|
hello @Sbragul26 , I have tried to replicate the issue on my side but i am not able to , |
|
Muse Code review: This is a valid fix direction for #1187 — the floating Kanvas card currently only adapts to viewport width, and the added height-aware sizing addresses the navbar overlap on low-height/landscape screens. I verified the touched file still matches the PR base on master, the PR is mergeable (CLEAN), checks pass (triage, CodeRabbit, DCO), and #1187 is still open. Findings below, ordered by importance. 1. Close button will scroll out of view (main issue) —
.kanvas-corner-popup .close-btn {
position: sticky;
top: 0.5rem;
margin-left: auto;
align-self: flex-end;
z-index: 1;
}Alternatively, move the scroll boundary to an inner wrapper so the button stays outside the scroll container. Either way, please verify at ~400px viewport height that the button remains reachable. 2. Hidden scrollbars hurt discoverability — A scrollable region with no visible scrollbar gives mouse/keyboard users no affordance that more content exists. Since scrolling only happens on short viewports, consider keeping the default (or 3. Magic navbar-height numbers — I found no matching navbar-height variable in // Measured against the docs navbar height (mobile nav wraps taller below ~768px).
--kanvas-navbar-height: 6rem;4. Minor:
overflow-wrap: break-word;5. Nits
No blocking concerns beyond item 1; with the close-button fix and a quick check at 360–450px viewport heights, this looks good to merge. |

This PR fixes the issue where the floating Kanvas card overlaps the navbar on low-height or landscape viewports.
Changes
Fixes #1187
Signed commits
Demo
Screencast.From.2026-08-07.17-09-27.mp4
Summary by CodeRabbit