fix(videos): remove hardcoded min suffix from durations#1064
fix(videos): remove hardcoded min suffix from durations#1064icoderarely wants to merge 3 commits into
Conversation
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1064/
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the ' min' suffix from the video duration display in the video landing page partial. The review feedback suggests improving the HTML structure by replacing the
tags with tags to avoid unnecessary inline styles and removing redundant CSS classes for better maintainability.
…ased styling Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Sbragul26
left a comment
Sbragul26
left a comment
There was a problem hiding this comment.
@icoderarely Just one small request , I noticed that in content/en/videos/integrations/aws/meshery-teaser.md, the duration value seems to be incorrect. Could you please update it to duration: "0:53" as well?
Other than that, the changes look good to me.
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Done! @Sbragul26 |
|
@icoderarely Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
3 participants
Notes for Reviewers
This PR fixes #1052
Signed commits