Skip to content

Fix stale tuple unpacking in mask-aware tile positions test - #11

Merged
barrettMCW merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Oct 13, 2026
Merged

barrettMCW merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Oct 13, 2026 •

Copy link
Copy Markdown

The test CI job failed in test_mask_aware_tile_positions_shift_per_row with ValueError: too many values to unpack (expected 2). _mask_aware_tile_positions now returns (x0_list, overlap_px, optimal_y0) 3-tuples, but the test still unpacked each run as a 2-tuple.

Changes

  • tests/test_shell.py: unpack top and bottom runs as x0s, _, _ instead of x0s, _.
# before
[x0 for x0s, _ in top for x0 in x0s] == [148]
# after
[x0 for x0s, _, _ in top for x0 in x0s] == [148]

This is a test-only change. The production code is untouched, and the expected x offsets (148 and 268) are unchanged.

Co-authored-by: barrettMCW <103449618+barrettMCW@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job test Fix stale tuple unpacking in mask-aware tile positions test Oct 13, 2026
Copilot AI requested a review from barrettMCW October 13, 2026 14:28
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@barrettMCW
barrettMCW marked this pull request as ready for review October 13, 2026 14:31
Copilot AI balanced review requested due to automatic review settings October 13, 2026 14:31
@barrettMCW
barrettMCW merged commit 2732c7b into main Oct 13, 2026
7 checks passed
@barrettMCW
barrettMCW deleted the copilot/fix-failing-github-actions-job branch October 13, 2026 14:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The test now correctly matches the function’s documented return type without changing behavior.

0 open findings

What changed in this PR

Updates a stale test to match _mask_aware_tile_positions’ three-value return structure.

Changes:

  • Unpacks all three tuple values while preserving existing offset assertions.
File Description
tests/​test_shell.py Fixes tuple unpacking in the mask-aware positioning test.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants