Repository navigation
Fix stale tuple unpacking in mask-aware tile positions test - #11
Merged
Merged
Conversation
Co-authored-by: barrettMCW <103449618+barrettMCW@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job test
Fix stale tuple unpacking in mask-aware tile positions test
Oct 13, 2026
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
🟢 Approval recommended
The test now correctly matches the function’s documented return type without changing behavior.
0 open findings
What changed in this PR
Updates a stale test to match _mask_aware_tile_positions’ three-value return structure.
Changes:
- Unpacks all three tuple values while preserving existing offset assertions.
| File | Description |
|---|---|
tests/test_shell.py |
Fixes tuple unpacking in the mask-aware positioning test. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testCI job failed intest_mask_aware_tile_positions_shift_per_rowwithValueError: too many values to unpack (expected 2)._mask_aware_tile_positionsnow returns(x0_list, overlap_px, optimal_y0)3-tuples, but the test still unpacked each run as a 2-tuple.Changes
tests/test_shell.py: unpacktopandbottomruns asx0s, _, _instead ofx0s, _.This is a test-only change. The production code is untouched, and the expected x offsets (148 and 268) are unchanged.