Skip to content

fix!: Do not add the targeting key as a custom attribute #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kinyoklion wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −1
Open

fix!: Do not add the targeting key as a custom attribute #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EvaluationContextConverter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ private function buildSingleContext(array $attributes, string $kind, string $key

foreach ($attributes as $k => $v) {
// Key has been processed, so we can skip it.
if ($k === "key" || $key === "targetingKey") {
if ($k === "key" || $k === "targetingKey") {
continue;
}

Expand Down
17 changes: 17 additions & 0 deletions tests/EvaluationContextConverterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,23 @@ public function testCanCreateMultiKindContext(): void
$this->assertEquals("Org name", $orgContext->getName());
}

public function testMultiContextTargetingKeyIsNotAddedAsAnAttribute(): void
{
$attributes = [
'kind' => 'multi',
'user' => ['targetingKey' => 'user-key', 'name' => 'User name']
];
$context = new EvaluationContext(null, new Attributes($attributes));

$ldContext = $this->contextConverter->toLdContext($context);

/** @var \LaunchDarkly\LDContext */
$userContext = $ldContext->getIndividualContext("user");
$this->assertEquals("user-key", $userContext->getKey());
$contextJson = $userContext->jsonSerialize();
$this->assertArrayNotHasKey("targetingKey", $contextJson);
}

public function testMultiContextDiscardsInvalidSingleKind(): void
{
$attributes = [
Expand Down
Loading