Repository navigation
fix(deps): remediate all open high severity dependabot advisories - #885
Merged
Merged
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
vadim-korolik
added a commit
that referenced
this pull request
Nov 17, 2026
…#890) ## Demo Dependency/config change with no visible runtime behaviour to record: this box has no mobile toolchain, so there is no Metro bundle and no Android/iOS build. What the commit after `0b91c27f` (`9ad49c8c`) verifies, from the repo root: | command | result | |---|---| | `yarn dedupe --check` | exit 0 — "No packages can be deduped" (the CI step that was red) | | `yarn install --immutable --mode=skip-build` | exit 0 — the regenerated lockfile is immutable-consistent | | `yarn workspace @launchdarkly/react-native-ld-session-replay test` | 1/1 suite, 21/21 tests pass (after the `@react-native/jest-preset` fix) | | `yarn turbo run build --filter=@launchdarkly/observability-react-native` | 3/3 tasks — typegen passes with `moduleResolution: bundler` | | `yarn turbo run build --filter=nextjs-ld` | 18/18 tasks — `e2e/nextjs-ld` builds (this is the `Build Yarn Turborepo` job) | `prettier --check` on the changed files | clean | `yarn install` itself exits non-zero only because two unrelated native build scripts (`puppeteer@17.1.3`, `msgpackr-extract`) cannot build in this sandbox; the lockfile/link steps complete and `--immutable` passes. ## Why #885 resolves `image-size` to `^2.0.3` to close the high-severity Dependabot advisories, but Metro still calls `require("image-size")(buffer)` synchronously and image-size 2.x is not callable, so a root `yarn install` breaks Metro for every workspace that runs it. The analysis in #885's `image-size` thread identified the two ways out: move RN/Expo to a Metro that supports image-size 2.x, or add a compatibility wrapper. This PR is the first option. **The upgrade target exists and is verified:** `metro` 0.87.1 — the first release with **no `image-size` dependency at all** (`metro`, `metro-config`, `metro-core`, `metro-transform-worker` all drop it), reached via `react-native@0.88.1` → `@react-native/metro-config@0.88.1` → `metro-config@^0.87.1`, and via Expo SDK 58's `@expo/metro@58` → `metro@0.87.1`. Metro 0.81–0.86 all still depend on `image-size@^1.0.2`, so SDK 57 / RN 0.86 is not enough. ## What changed | workspace | before | after | |---|---|---| | `e2e/react-native` | Expo 52, RN 0.76.6, react 18.3 | Expo 58, RN 0.88.1, react 19.3 | | `e2e/react-native-otel` | Expo 53, RN 0.79.4 | Expo 58, RN 0.88.1 | | `sdk/@launchdarkly/observability-react-native` | dev RN `^0.79.0` | dev RN `^0.88.0` (peer `>=0.70.0` unchanged) | | `sdk/@launchdarkly/react-native-ld-session-replay` | dev RN `0.83.0` | dev RN `0.88.1` (peer `*` unchanged) | The `image-size: ^1.2.1` npm override in `e2e/react-native` is dropped — it existed only to keep Metro on 1.x. `yarn.lock` regenerated. `@launchdarkly/observability-next` gains a `react-dom ^19.0.0` devDependency: its nested `next` 16 peer-requires react-dom, and before this PR react-dom only resolved because it happened to be hoisted to the workspace root (`e2e/nextjs-ld`'s build failed on `Cannot find module 'react-dom/server.browser'` once react 19.3 re-hoisted it). All expo-* versions come from `expo@58.0.23`'s own `bundledNativeModules.json`, and `expo` is held at `~58.0.23` to respect the repo's `npmMinimalAgeGate: 7d`. ## This does NOT close the dependabot alerts yet — here is what is left Three consumers keep `image-size` 1.x alive, so a blanket `^2.0.3` resolution would still break them: 1. **`sdk/@launchdarkly/react-native-ld-session-replay/example`** pins RN 0.83.0 (Metro 0.83 → `image-size@^1.0.2`). Mechanical to move to 0.88, but it is a bare RN app with native builds this change could not validate. 2. **`.../example-legacy`** pins RN 0.78.0 (Metro 0.81) **on purpose** — it is the backward-compatibility example. Upgrading it deletes that coverage, so this is a maintainer call, not a mechanical bump. 3. **`less@4.2.2`**, pulled in by `@angular-devkit/build-angular` in `e2e/angular`, does exactly: ```js var sizeOf = require('image-size'); return sizeOf(fileSync.filename); // less/lib/less-node/image-size.js ``` image-size 2.1.0's CJS export is `{ disableTypes, imageSize, default, types }` — not callable, and it takes a `Uint8Array`, not a path. **This is a second, independent break in #885 that has nothing to do with Metro:** the Less `image-size()`, `image-width()` and `image-height()` functions throw once the lock forces 2.x. So the end state should be a **descriptor-scoped** resolution (`image-size@^1.0.2` → 1.x for the remaining Metro/Less consumers, `image-size` → `^2.0.3` for the rest) rather than #885's blanket bump, plus this PR's Metro 0.87 upgrade so the scoped 1.x set shrinks to just the legacy example and Less, or those two get dealt with separately. ## Not verified - No Metro bundle, no Android/iOS build and no `expo start` — this environment has no mobile toolchain. `yarn install` resolves and links cleanly; the one remaining peer warning is `@react-native/metro-config` requested by `react-native-worklets` (Expo apps build Metro through `expo/metro-config`; the peer is `*` and does not fail CI). - `expo install --fix` was not run; versions were taken from `bundledNativeModules.json` directly. - The session-replay Jest suite passes (21/21) but the apps' own Jest suites were not run one by one; root `yarn test` was not run. This is a major-version migration of two example apps and has not had a real Metro run yet (no mobile toolchain on the box). The follow-up commit `9ad49c8c` fixes the CI red and two Bugbot Highs: it adds the missing `react-native-worklets@0.13.0` peer to both e2e apps (Expo SDK 58's own pin), repairs the session-replay Jest preset (`@react-native/jest-preset` 0.88.1 instead of the removed `react-native` stub) and moves its RN tooling to 0.88.1 / react 19.3.0, dedupes the lockfile, and switches `observability-react-native`'s typegen to `moduleResolution: bundler` (RN 0.88 ships exports-only types). 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Upgrades both React Native **e2e** apps (`e2e/react-native`, `e2e/react-native-otel`) to **Expo SDK 58**, **React Native 0.88.1**, **React 19.3**, and aligned Expo/native deps—including **`react-native-reanimated` 4.7.1** and the **`react-native-worklets`** pin required for SDK 58. The `e2e/react-native` **`image-size` npm override** is removed so Metro can move forward without forcing `image-size` 1.x. > > SDK packages are bumped in lockstep: **`@launchdarkly/observability-react-native`** dev RN **^0.88.0** and **`moduleResolution: bundler`** for typegen on RN 0.88 export-only types; **`@launchdarkly/react-native-ld-session-replay`** dev/tooling and Jest **`@react-native/jest-preset` 0.88.1**. > > Small app fixes for the new stack: **`HomeScreen`** reads LaunchDarkly context and `test-flag` via **`useState` lazy initializers** (no mount `useEffect`); **`HelloWave`** uses Reanimated v4’s **`.set()`** instead of assigning **`.value`** for the wave animation. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 370e596. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Code <noreply@anthropic.com>
vadim-korolik
force-pushed
the
fix/high-severity-vulns
branch
from
November 17, 2026 20:00
80b0099 to
e8570e5
Compare
vadim-korolik
force-pushed
the
fix/high-severity-vulns
branch
from
November 17, 2026 20:13
e8570e5 to
b69ead8
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b69ead8. Configure here.
Patch every open HIGH-severity Dependabot alert in the monorepo that has a patched release: - npm (yarn): bump the Angular e2e app from 19 to 20.3.35 (no patched 19.x exists), Vite 5 -> 6.4.5 for @launchdarkly/o11y, and add root resolutions for basic-ftp, happy-dom, markdown-it, joi, toml, zod, nanoid, @graphql-tools/utils, pacote and @fastify/busboy. Puppeteer 25 also drops the unfixable extract-zip dependency. - Go: bump google.golang.org/grpc to v1.83.2 in all six modules. - Python: update fsspec to 2026.9.0 in both Poetry locks. - Ruby: bump rack to 3.2.8 in the Sinatra e2e app. - NuGet: drop the unused OpenTelemetry.Resources.Host 0.1.0-beta.2 dependency, whose patched version requires an OpenTelemetry 1.16 migration. decode-uri-component is resolved by removing it rather than by pinning it: its only fixed release (0.5.1) is ESM-only, and query-string@7 requires it from CommonJS, so forcing 0.5.1 breaks query-string at runtime. Re-resolving @react-navigation/core to 7.24.0 (>= 7.22.1 dropped query-string) removes query-string and decode-uri-component from the yarn graph entirely, which fixes the advisory with no behavioural change. e2e/react-native is left as it is on main and needs no override. @launchdarkly/o11y now builds with Vite 6. Because Vite 6's inline worker pipeline cannot statically analyse cross-fetch's UMD ponyfill, route it through a small CJS shim (shims/cross-fetch.cjs) and build commonjs with strictRequires: 'auto'. The shim's module.exports is the fetch function itself (with .default/.fetch self-references) so a default import stays callable under @rollup/plugin-commonjs's interop, and Headers/Request/Response fall back to the platform globals so they are never undefined at runtime. The inline worker is deliberately left at Vite's default 'iife' format: the worker is instantiated from a blob: URL, and a module worker (what 'es' emits) does not load in the older browsers the es6 build target still covers. image-size is resolved per descriptor: image-size@^1.0.2 stays on the last 1.x for the two SDK example apps still on Metro 0.81/0.83 (one of them is the deliberately-legacy RN 0.78 example), while the catch-all resolution moves to ^2.0.3. #890 already moved the Expo e2e apps to Metro 0.87, which does not use image-size at all, so no other consumer is affected. Dependabot has no patched 1.x, so the two yarn.lock image-size alerts (1436/1437) remain open and are tracked as a maintainer decision on the legacy example. yarn.lock regenerated and deduped. Co-Authored-By: Claude Code <noreply@anthropic.com> Generated-by: termag
vadim-korolik
force-pushed
the
fix/high-severity-vulns
branch
from
November 17, 2026 20:25
b69ead8 to
1252fb4
Compare
abelonogov-ld
approved these changes
Nov 17, 2026
Merged
vadim-korolik
added a commit
that referenced
this pull request
Nov 17, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-python: 1.4.1</summary> ## [1.4.1](launchdarkly-observability-python-1.4.0...launchdarkly-observability-python-1.4.1) (2026-11-17) ### Bug Fixes * **deps:** remediate all open high severity dependabot advisories ([#885](#885)) ([55eeab2](55eeab2)) * remediate next, react-server-dom-webpack, bouncycastle, anyio, handlebars and dependency advisories ([#757](#757)) ([08b8067](08b8067)) </details> <details><summary>launchdarkly_flutter_observability: 1.0.3</summary> ## [1.0.3](launchdarkly_flutter_observability-1.0.2...launchdarkly_flutter_observability-1.0.3) (2026-11-17) ### Bug Fixes * remediate next, react-server-dom-webpack, bouncycastle, anyio, handlebars and dependency advisories ([#757](#757)) ([08b8067](08b8067)) </details> <details><summary>go: 1.4.1</summary> ## [1.4.1](go/v1.4.0...go/v1.4.1) (2026-11-17) ### Bug Fixes * **deps:** remediate all open high severity dependabot advisories ([#885](#885)) ([55eeab2](55eeab2)) * remediate next, react-server-dom-webpack, bouncycastle, anyio, handlebars and dependency advisories ([#757](#757)) ([08b8067](08b8067)) </details> <details><summary>o11y: 1.7.0</summary> ## [1.7.0](o11y-1.6.0...o11y-1.7.0) (2026-11-17) ### Features * **o11y:** add enableFlagEvaluationSpans option to disable flag evaluation spans ([#886](#886)) ([ad375b8](ad375b8)) ### Bug Fixes * **deps:** remediate all open high severity dependabot advisories ([#885](#885)) ([55eeab2](55eeab2)) * remediate next, react-server-dom-webpack, bouncycastle, anyio, handlebars and dependency advisories ([#757](#757)) ([08b8067](08b8067)) </details> <details><summary>observability: 1.5.1</summary> ## [1.5.1](observability-1.5.0...observability-1.5.1) (2026-11-17) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/o11y bumped to 1.7.0 </details> <details><summary>observability-next: 0.3.7</summary> ## [0.3.7](observability-next-0.3.6...observability-next-0.3.7) (2026-11-17) ### Bug Fixes * **deps:** move the React Native e2e apps to Expo SDK 58 (Metro 0.87) ([#890](#890)) ([6913230](6913230)) * remediate next, react-server-dom-webpack, bouncycastle, anyio, handlebars and dependency advisories ([#757](#757)) ([08b8067](08b8067)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/observability bumped to 1.5.1 * @launchdarkly/observability-node bumped to 1.5.0 * @launchdarkly/session-replay bumped to 1.2.7 </details> <details><summary>observability-node: 1.5.0</summary> ## [1.5.0](observability-node-1.4.0...observability-node-1.5.0) (2026-11-17) ### Features * **observability-node:** add a register entry point that instruments ES modules ([#891](#891)) ([46513dc](46513dc)) * **observability-node:** add instrumentationConfig option to NodeOptions ([#887](#887)) ([66840b4](66840b4)) ### Bug Fixes * **observability-node:** report success when sampling drops a whole batch ([#889](#889)) ([76b1adb](76b1adb)) </details> <details><summary>observability-react-native: 0.21.1</summary> ## [0.21.1](observability-react-native-0.21.0...observability-react-native-0.21.1) (2026-11-17) ### Bug Fixes * **deps:** move the React Native e2e apps to Expo SDK 58 (Metro 0.87) ([#890](#890)) ([6913230](6913230)) </details> <details><summary>session-replay: 1.2.7</summary> ## [1.2.7](session-replay-1.2.6...session-replay-1.2.7) (2026-11-17) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/o11y bumped to 1.7.0 </details> <details><summary>session-replay-react-native: 0.25.2</summary> ## [0.25.2](session-replay-react-native-0.25.1...session-replay-react-native-0.25.2) (2026-11-17) ### Bug Fixes * **deps:** move the React Native e2e apps to Expo SDK 58 (Metro 0.87) ([#890](#890)) ([6913230](6913230)) * remediate next, react-server-dom-webpack, bouncycastle, anyio, handlebars and dependency advisories ([#757](#757)) ([08b8067](08b8067)) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/observability-react-native bumped to 0.21.1 </details> <details><summary>highlight.run: 10.8.7</summary> ## [10.8.7](highlight.run-10.8.6...highlight.run-10.8.7) (2026-11-17) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/o11y bumped to 1.7.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > This is a **Release Please** cut that bumps published versions across the monorepo (Go, browser `o11y`/`observability`/`session-replay`, Node, Python, React Native, Flutter, Next wrapper, and `highlight.run`) via `.release-please-manifest.json`, package manifests, changelogs, and embedded version constants. > > The **notable product notes** carried in the new changelog entries include: **`@launchdarkly/o11y` 1.7.0** with an `enableFlagEvaluationSpans` option to turn off flag evaluation spans; **`@launchdarkly/observability-node` 1.5.0** with a register entry point for ES module instrumentation, an `instrumentationConfig` on `NodeOptions`, and a fix when sampling drops an entire batch; plus dependency and advisory remediation and RN e2e moves to Expo SDK 58 called out across several packages. > > **CI:** the Flutter observability workflow now pins **`FLUTTER_VERSION: 3.47.9`** and passes it to all three `subosito/flutter-action` installs, so stable Flutter drift (Gradle 9.3.1+ and future `material`/`cupertino` deprecations) cannot break the pipeline without an intentional bump. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 726794c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Vadim Korolik <vkorolik@launchdarkly.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Remediates every open high-severity Dependabot alert in the repository that has a patched release. Rebased onto
main, so this now includes #890 (Expo SDK 58 / React Native 0.88.1 / Metro 0.87) and is a single squashed commit.What changed
@angular/{core,common,compiler,router,...}(e2e/angular)ng buildpassesvite(used by@launchdarkly/o11y)vite5→vite6; Vite 5 has no patched 5.xbasic-ftpget-uriunchanged)happy-dom@react-navigation/{core,native,bottom-tabs}query-string, which removesdecode-uri-component0.2.2 from the graph entirelymarkdown-itjoitomlnanoid@graphql-tools/utils@fastify/busboyfirebase-admin11 → 12.7.0 in e2e/functionspacotepuppeteer/puppeteer-core/@puppeteer/browsersextract-zipadvisoryzodgoogle.golang.org/grpcgo/,sdk/highlight-go, four e2e modules)fsspecrackOpenTelemetry.Resources.Hoste2e/dotnet4; the patched 1.16.0-beta.2 requires an OpenTelemetry 1.16 / Microsoft.Extensions 10 migrationVite 6 build adaptation
@launchdarkly/o11ynow builds with Vite 6.4.5. Vite 6's inline worker bundler cannot statically analysecross-fetch's UMD browser ponyfill (it reassignsexportsbefore setting its properties), sographql-request's named imports failed to resolve. The config aliasescross-fetchto a small CJS shim (sdk/@launchdarkly/o11y/shims/cross-fetch.cjs) and setsstrictRequires: 'auto'on the commonjs transform.The shim's
module.exportsis the fetch function (with.default/.fetchself-references), because@rollup/plugin-commonjsbinds a default import tomodule.exportsunless__esModuleis set;Headers/Request/Responsecome from the ponyfill and fall back to the platform globals. No runtime behaviour change.The inline worker stays at Vite's default
iifeformat. Anesworker is emitted as a module worker, and the worker is instantiated from ablob:URL, which older browsers covered by thees6build target cannot load — so noworker.formatoverride is left in the config.decode-uri-componentis removed, not pinnedThe only fixed release, 0.5.1, is ESM-only (
"type": "module", no CommonJS entry), whilequery-string@7doesrequire('decode-uri-component'). Pinning 0.5.1 therefore breaksquery-stringat runtime:query-stringis only pulled in by@react-navigation/core< 7.22.1. Re-resolving@react-navigation/{core,native,bottom-tabs}to7.24.0/7.5.1/7.21.0drops that dependency, soquery-stringanddecode-uri-componentleave the yarn graph with no override and no behavioural change.e2e/react-nativeis left exactly as it is onmain.image-size is now descriptor-scoped
image-size2.x is not callable (require('image-size')returns a namespace and takes aUint8Array), while Metro 0.81–0.83 callsrequire('image-size')(buffer). After #890 moved the Expo e2e apps to Metro 0.87 — which has noimage-sizedependency — the only consumers left in the workspace graph are the two SDK example apps still on older React Native:So the resolution is scoped instead of blanket:
example-legacyis pinned to the legacy architecture on purpose (session-replay-legacy-arch.ymlbuilds it), so it cannot move to Metro 0.87 in this change.Alerts this PR does not close
image-size1436/1437 (yarn.lock)image-size1434/1435,decode-uri-component1720 (e2e/react-native/package-lock.json)workspace:*dependencies (EUNSUPPORTEDPROTOCOL). The yarn graph the workspace actually installs from is clean for this app — Metro 0.87 (noimage-size) and@react-navigation/core7.24.0 (noquery-string) — so these entries exist only in the frozen lock file. Refreshing or dropping that file is a separate change.picomatch1975/1976<= 4.0.7and no patched version has been published yet.@sveltejs/kit1970rrwebsubmodule — separate change.Demo
Dependency-only change, so the demo is the patched versions plus build/test evidence.
Resolved versions in
yarn.lockafter the change:google.golang.org/grpc v1.83.2in all six Go modules;fsspec = 2026.9.0in both Poetry locks;rack (3.2.8);OpenTelemetry.Resources.Hostgone frome2e/dotnet4.Verification run locally (after rebase on main, cold turbo cache):
Overlap
Open PR #834 (
devin/dep-vulns-major-batch) touches some of the same packages (toml,basic-ftp,fsspec,firebase-admin). This PR is scoped to the currently open high-severity advisories and also covers the Angular 20, Vite 6, Go, Ruby and NuGet items; whichever lands second will need a rebase.🤖 Generated with Claude Code
Opened from termag
Note
Overview
This PR bumps vulnerable dependencies across npm, Go, Python, Ruby, and NuGet, driven by open high-severity Dependabot alerts and coordinated through root yarn resolutions plus targeted manifest updates.
On npm, notable moves include
e2e/angularto Angular 20.3.x (from 19.x),@launchdarkly/o11yfrom Vite 5 → 6 (vite5→vite6),e2e/nextjszodto 4.6.7,e2e/functionsfirebase-adminto ^12.7.0, and many workspace-wide resolution bumps (happy-dom,basic-ftp,puppeteer, scopedimage-size,vite, etc.).The only behavioral build change in SDK code is the Vite 6 adaptation for
@launchdarkly/o11y: a newshims/cross-fetch.cjsandvite.config.tsalias/CommonJSstrictRequiressographql-requeststill gets a callablefetchafter Vite’s stricter CJS analysis.Go modules uniformly move
google.golang.org/grpcto 1.83.2 (and relatedgolang.org/x/*in some e2e trees). Python Poetry locks refreshfsspecto 2026.9.0.e2e/ruby/sinatralocksrackat 3.2.8.e2e/dotnet4drops the unusedOpenTelemetry.Resources.Hostpackage/reference instead of a major OTel upgrade.Reviewed by Cursor Bugbot for commit 1252fb4. Bugbot is set up for automated code reviews on this repo. Configure here.