Skip to content

fix(deps): remediate all open critical dependabot advisories - #883

Merged
vadim-korolik merged 5 commits into
mainfrom
fix/critical-security-advisories
Nov 13, 2026
Merged

vadim-korolik merged 5 commits into
mainfrom
fix/critical-security-advisories

Conversation

@vadim-korolik

@vadim-korolik vadim-korolik commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Remediates every open critical Dependabot alert in this repository: 15 alerts covering 9 unique advisories across npm, pip and RubyGems. All changes are dependency and lockfile updates; no SDK source code changes.

Alerts addressed (open critical alerts as of this PR):

Advisory Package Vulnerable range Resolved to Manifests Alerts
GHSA-82r6-8w77-94w6 / CVE-2026-63374 anyio < 4.14.2 4.16.0 e2e/python, e2e/python-plugin-flask, sdk/@launchdarkly/observability-python, sdk/highlight-py (poetry.lock) 4
GHSA-f3w6-w445-fwh9 / CVE-2026-122006 activestorage (Rails) < 8.0.5.2 8.0.5.2 e2e/ruby/rails/demo, api-only, demo-rails70 (Gemfile, Gemfile.lock) 3
GHSA-xqc2-xf4c-x3h3 / CVE-2026-126187 react-server-dom-webpack >= 19.2.0, < 19.2.9 19.3.1 yarn.lock 1
GHSA-2464-fhr4-w9xw next >= 10.0.0, <= 15.5.27 15.5.29 (15.x); 16.4.3 (16.x) yarn.lock 1
GHSA-9v8h-qqgm-4m35 / CVE-2026-111497 brotli >= 1.0.3, < 1.2.1 1.2.1 e2e/tests (poetry.lock) 1
GHSA-p8wg-vrv2-v86f / CVE-2026-106445 handlebars >= 3.0.0, <= 4.7.9 4.7.10 yarn.lock 1
GHSA-8r5x-fm3f-whwj / CVE-2026-106446 handlebars >= 4.0.0, <= 4.7.9 4.7.10 yarn.lock 1
GHSA-pqg4-j6r4-53mv / CVE-2026-102422 shell-quote >= 1.8.4, < 1.11.0 1.12.0 yarn.lock, e2e/react-native/package-lock.json 2
GHSA-67c8-pqhq-4rmx / CVE-2026-102992 piscina < 4.9.4 4.9.4 yarn.lock 1

What changed

  • npm (package.json resolutions + yarn.lock, e2e/react-native overrides/lock):
    next 15.5.27 -> 15.5.29, react-server-dom-webpack 19.2.8 -> 19.3.1, handlebars 4.7.9 -> 4.7.10,
    shell-quote 1.10.0 -> 1.12.0, piscina 4.9.3 -> 4.9.4.
  • pip (poetry.lock): anyio 4.9.0 -> 4.16.0 in all four locks, and the typing-extensions floor moved to 4.16.0;
    brotli 1.2.0 -> 1.2.1 in e2e/tests.
  • RubyGems (Gemfile + regenerated Gemfile.lock): all three e2e Rails apps move from the Rails 7.2 line to
    rails ~> 8.0.5.2. 8.0.5.2 is the first release patched for the activestorage advisory and there is no 7.2 backport,
    so the e2e apps cannot stay on 7.2 and remain clean. demo-rails70's existing json ~> 2.19.9 pin is retained
    (Rails 8 still cannot use json 3.x). Its README is updated to explain that it no longer exercises the Rails 7 line.

Demo

This is a dependency/lockfile-only change, so the demo is the verification output rather than a recording.

$ yarn dedupe --check          # exit 0
$ yarn install --immutable     # exit 0
$ yarn build:sdk               # 22/22 packages successful

# resolved versions
yarn.lock: next 15.5.29 (15.x), next 16.4.3 (16.x), react-server-dom-webpack 19.3.1,
           handlebars 4.7.10, shell-quote 1.12.0, piscina 4.9.4
e2e/python, e2e/python-plugin-flask, observability-python, highlight-py:
           anyio 4.16.0 (confirmed via importlib.metadata)
e2e/tests: brotli 1.2.1

# npm test suite
hono example tests: 15/15 passing

# Rails e2e apps (Docker, ruby:3.3.4)
demo:         4 runs, 11 assertions, 0 failures
api-only:     3 runs,  5 assertions, 0 failures
demo-rails70: 6 runs, 19 assertions, 0 failures

# Rails locks
activestorage (8.0.5.2) / rails (8.0.5.2) / json (2.19.9)

Notes

🤖 Generated with Claude Code

Opened from termag


Note

Overview
All three Ruby Rails e2e fixtures (demo, api-only, demo-rails70) move from the 7.2 line to rails ~> 8.0.5.2 with regenerated Gemfile.lock files. 8.0.5.2 is documented as the first release that fixes the critical Active Storage arbitrary file write/read advisory (GHSA-f3w6-w445-fwh9 / CVE-2026-122006); there is no 7.2 backport, so staying on 7.2 would keep Dependabot alerts open.

demo-rails70 keeps its existing minitest ~> 5.0 and json ~> 2.19.9 pins; only the Rails constraint and comments change. Its README is updated to note the app now runs Rails 8 while still using config.load_defaults 7.0, and that it no longer provides Rails 7.0 regression coverage (CI job name unchanged).

Lockfile churn includes the full Rails 8 stack (e.g. activestorage 8.0.5.2), plus transitive updates such as rails-html-sanitizer 1.7.2, minitest 6.x where unpinned (api-only), and new uri dependency from activesupport 8.

Reviewed by Cursor Bugbot for commit bad4fd1. Bugbot is set up for automated code reviews on this repo. Configure here.

vadim-korolik and others added 4 commits November 13, 2026 20:34
GHSA-82r6-8w77-94w6 (anyio < 4.14.2, TLS certificate spoofing) is fixed
by relocking to 4.16.0 in e2e/python and both Python SDK packages; the
transitive typing-extensions floor moves to 4.16.0 as anyio requires.

GHSA-9v8h-qqgm-4m35 (brotli < 1.2.1, out-of-bounds write) is fixed by
relocking e2e/tests to 1.2.1.

Co-Authored-By: Claude Code <noreply@anthropic.com>
Address GHSA-f3w6-w445-fwh9 / CVE-2026-122006 by moving the three Rails
e2e apps from 7.2.3.2 to 8.0.5.2, the first patched release; no 7.2
backport exists. Regenerate each Gemfile.lock with Ruby 3.3.4 /
Bundler 2.5.11 and update the demo-rails70 docs to match.

Co-Authored-By: Claude Code <noreply@anthropic.com>
Bump root yarn resolutions to patched releases:
- next ^15.5.27 -> ^15.5.28 (resolves 15.5.29), fixing GHSA-2464-fhr4-w9xw
  (RCE via Image Optimization). The 16.x resolutions already resolve to
  16.4.3, which is above the patched 16.4.1.
- react-server-dom-webpack ^19.2.8 -> ^19.2.9 (resolves 19.3.1), fixing
  GHSA-xqc2-xf4c-x3h3.
- handlebars ^4.7.9 -> ^4.7.10, fixing GHSA-p8wg-vrv2-v86f and
  GHSA-8r5x-fm3f-whwj.
- shell-quote ^1.9.0 -> ^1.11.0 (resolves 1.12.0), fixing
  GHSA-pqg4-j6r4-53mv, in both yarn.lock and the e2e/react-native npm lock.
- piscina ^4.9.3 -> ^4.9.4, fixing GHSA-67c8-pqhq-4rmx without jumping
  to the incompatible 5.x line.

Co-Authored-By: Claude Code <noreply@anthropic.com>
GHSA-82r6-8w77-94w6 (anyio < 4.14.2): the lock introduced with the
rebased pip group still resolved 4.9.0. Relock to 4.16.0 (typing-extensions
floor moves to 4.16.0).

Co-Authored-By: Claude Code <noreply@anthropic.com>
@vadim-korolik
vadim-korolik requested a review from a team as a code owner November 13, 2026 21:11
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
628 551 88% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: b4038f0 by action🐍

@zack-winchell-ld zack-winchell-ld left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadim-korolik should this PR also bump the SDK version? Do we require standalone version bump PRs?

@vadim-korolik

Copy link
Copy Markdown
Contributor Author

No version bump needed here. Nothing under a published artifact changes: the diff is lockfiles and manifest pin ranges (poetry.lock, Gemfile/Gemfile.lock, yarn.lock) — lockfiles are not shipped inside the npm/pip/gem tarballs, and no SDK source or public API changes. The repo has no changeset/enforced-bump gate (Do Not Merge checker and lint-pr-title both pass on this head), and releasing a new SDK version for a lockfile would publish an identical artifact under a new version number. If your release process does require a bump for dependency-only changes, say the word and I will add it — but standalone version-bump PRs are not needed for this one.

@vadim-korolik vadim-korolik added the merge-ready Approved, CI green, Bugbot clean, no open threads label Nov 13, 2026
Lockfiles already remediated by main's #757 (python/poetry locks, npm
package.json + package-lock, yarn.lock) taken from origin/main; kept this
branch's Rails 8.0.5.2 e2e upgrade for the activestorage advisory, which
main does not cover.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@vadim-korolik

Copy link
Copy Markdown
Contributor Author

Merged main in (bad4fd1bbf) — the PR went dirty when #757 (08b8067e32, devin-ai-integration) landed the same critical-advisory remediation on main at 22:16Z.

Resolution: for every file both sides touched (package.json, yarn.lock, e2e/react-native/*, e2e/python*/poetry.lock, sdk/*/poetry.lock) I took main's version — #757 supersedes every bump this PR made (equal-or-newer) and adds ~60 more. No installs were run; no lockfile was hand-regenerated.

The PR is not redundant: main does not touch e2e/ruby/ at all, so the Rails 8.0.5.2 / activestorage CVE work is unique. After the merge the diff vs main is 7 files, all under e2e/ruby/rails/.

Two things for @vadim-korolik to decide:

  1. anyio is now 4.14.2 in e2e/python, sdk/@launchdarkly/observability-python and sdk/highlight-py (main's pin) instead of the PR's 4.16.0. Main itself ships 4.16.0 in e2e/python-plugin-flask, so main is internally inconsistent — a poetry update anyio follow-up fixes it properly (couldn't regenerate lockfiles offline).
  2. The title now overstates the diff: after the merge this is effectively "Rails e2e apps to 8.0.5.2". Optional retitle.

@vadim-korolik
vadim-korolik merged commit 347be78 into main Nov 13, 2026
34 checks passed
@vadim-korolik
vadim-korolik deleted the fix/critical-security-advisories branch November 13, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-ready Approved, CI green, Bugbot clean, no open threads

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants