chore(deps): remove stray npm lockfile pinning vulnerable vitest 3.2.4#1945
Open
kparkinson-ld wants to merge 2 commits into
Open
chore(deps): remove stray npm lockfile pinning vulnerable vitest 3.2.4#1945kparkinson-ld wants to merge 2 commits into
kparkinson-ld wants to merge 2 commits into
Conversation
The repo is pnpm-managed (packageManager pnpm@11.0.1, pnpm-lock.yaml has vitest 4.1.8). The tracked package-lock.json was a stale npm lockfile (removed in #1678, reappeared) pinning vitest 3.2.4, which triggered a critical Dependabot alert (patched in 3.2.6). Remove it and gitignore it to prevent recurrence.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the critical Dependabot alert for
vitest(< 3.2.6) in this repo.The repo is pnpm-managed (
packageManager: pnpm@11.0.1;pnpm-lock.yamlalready resolvesvitest@4.1.8, and rootpackage.jsondeclaresvitest: ^4.1.8). The trackedpackage-lock.jsonwas a stale npm lockfile that was out of sync with the pnpm workspace and still pinnedvitest@3.2.4(< patched3.2.6), which is what triggered the alert. Nothing (CI, scripts,packageManager) uses it.This file was already removed once in #1678 (
chore: remove npm lockfile) but later reappeared. This PR removes it again and addspackage-lock.jsonto.gitignoreto prevent recurrence.Screenshots (if appropriate):
N/A — tooling/dependency change, no runtime or UI impact.
Testing approaches
No functional change. The active toolchain (pnpm +
pnpm-lock.yaml) already usesvitest@4.1.8, so tests/build are unaffected by removing the unused npm lockfile. CI (pnpm-basedverify.yml) validates.Link to Devin session: https://app.devin.ai/sessions/91d8c10355aa49d1811295b1c02b703b
Requested by: @kparkinson-ld
Note
Low Risk
Tooling-only lockfile and ignore-list change; no application code, auth, or runtime behavior is affected.
Overview
Clears a Dependabot alert on vulnerable
vitest(< 3.2.6) by dropping a stale, trackedpackage-lock.jsonthat pinnedvitest@3.2.4while the repo actually runs on pnpm (packageManager: pnpm@11.0.1,pnpm-lock.yamlwithvitest@4.1.8).Adds
package-lock.jsonto.gitignoreso an npm lockfile is less likely to be committed again after a prior removal in #1678.Reviewed by Cursor Bugbot for commit aa3dfaf. Bugbot is set up for automated code reviews on this repo. Configure here.