Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 91 additions & 16 deletions libs/client-sdk/src/client_impl.cpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#include "client_impl.hpp"
#include "data_sources/fdv2/fdv2_data_source.hpp"
#include "data_sources/fdv2/mode_sources.hpp"
#include "data_sources/null_data_source.hpp"
#include "data_sources/polling_data_source.hpp"
#include "data_sources/streaming_data_source.hpp"
Expand Down Expand Up @@ -31,12 +33,67 @@
using launchdarkly::config::shared::built::DataSourceConfig;
using launchdarkly::config::shared::built::HttpProperties;

using FDv2Config = config::shared::built::FDv2Config<ClientSDK>;

namespace {

template <class... Ts>
struct overloaded : Ts... {
using Ts::operator()...;
};
template <class... Ts>
overloaded(Ts...) -> overloaded<Ts...>;

} // namespace

static bool UsesFDv2(Config const& config) {
return std::holds_alternative<FDv2Config>(config.DataSourceConfig().method);
}

static std::shared_ptr<data_sources::IDataSource> MakeFDv2DataSource(
HttpProperties const& http_properties,
Config const& config,
FDv2Config const& fdv2,
Context const& context,
boost::asio::any_io_executor const& executor,
flag_manager::FlagManager& flag_manager,
data_sources::DataSourceStatusManager& status_manager,
Logger& logger) {
auto const& endpoints = config.ServiceEndpoints();

if (config.DataSourceConfig().use_report) {
LD_LOG(logger, LogLevel::kWarn)
<< "UseReport is not applicable to FDv2 and will be ignored";
}

data_sources::ModeSourceParams const params{
executor,
logger,
http_properties,
endpoints,
context,
config.DataSourceConfig().with_reasons,
&flag_manager.Cache()};

auto sources =
data_sources::BuildModeSources(fdv2, fdv2.initial_mode, params);

return std::make_shared<data_sources::FDv2DataSource>(
std::move(sources.initializers), std::move(sources.synchronizers),
std::make_unique<data_sources::FallbackConditionFactory>(
executor, fdv2.fallback_timeout),
std::make_unique<data_sources::RecoveryConditionFactory>(
executor, fdv2.recovery_timeout),
executor, context, &flag_manager.Updater(), &flag_manager.Store(),
&status_manager, logger);
}

static std::shared_ptr<data_sources::IDataSource> MakeDataSource(
HttpProperties const& http_properties,
Config const& config,
Context const& context,
boost::asio::any_io_executor const& executor,
IDataSourceUpdateSink& flag_updater,
flag_manager::FlagManager& flag_manager,
data_sources::DataSourceStatusManager& status_manager,
Logger& logger) {
if (config.Offline()) {
Expand All @@ -48,18 +105,30 @@

auto data_source_properties = builder.Build();

if (config.DataSourceConfig().method.index() == 0) {
return std::make_shared<
launchdarkly::client_side::data_sources::StreamingDataSource>(
config.ServiceEndpoints(), config.DataSourceConfig(),
data_source_properties, executor, context, flag_updater,
status_manager, logger);
}
return std::make_shared<
launchdarkly::client_side::data_sources::PollingDataSource>(
config.ServiceEndpoints(), config.DataSourceConfig(),
data_source_properties, executor, context, flag_updater, status_manager,
logger);
return std::visit(
overloaded{
[&](config::shared::built::StreamingConfig<ClientSDK> const&)
-> std::shared_ptr<data_sources::IDataSource> {
return std::make_shared<data_sources::StreamingDataSource>(
config.ServiceEndpoints(), config.DataSourceConfig(),
data_source_properties, executor, context,
flag_manager.Updater(), status_manager, logger);
},
[&](config::shared::built::PollingConfig<ClientSDK> const&)
-> std::shared_ptr<data_sources::IDataSource> {
return std::make_shared<data_sources::PollingDataSource>(
config.ServiceEndpoints(), config.DataSourceConfig(),
data_source_properties, executor, context,
flag_manager.Updater(), status_manager, logger);
},
[&](FDv2Config const& fdv2)
-> std::shared_ptr<data_sources::IDataSource> {
return MakeFDv2DataSource(data_source_properties, config, fdv2,
context, executor, flag_manager,
status_manager, logger);
},
},
config.DataSourceConfig().method);
}

static Logger MakeLogger(config::shared::built::Logging const& config) {
Expand Down Expand Up @@ -101,13 +170,17 @@
MakePersistence(config_)),
data_source_factory_([this]() {
return MakeDataSource(http_properties_, config_, context_,
ioc_.get_executor(), flag_manager_.Updater(),
ioc_.get_executor(), flag_manager_,
status_manager_, logger_);
}),
data_source_(nullptr),
event_processor_(nullptr),
eval_reasons_available_(config_.DataSourceConfig().with_reasons) {
flag_manager_.LoadCache(context_);
// Under FDv2 the cache is loaded by an initializer, so that it enters the
// store through the same path as every other source.
if (!UsesFDv2(config_)) {
flag_manager_.LoadCache(context_);
}

if (auto custom_ca = http_properties_.Tls().CustomCAFile()) {
LD_LOG(logger_, LogLevel::kInfo)
Expand Down Expand Up @@ -160,7 +233,9 @@

std::future<bool> ClientImpl::IdentifyAsync(Context context) {
UpdateContextSynchronized(context);
flag_manager_.LoadCache(context);
if (!UsesFDv2(config_)) {
flag_manager_.LoadCache(context);
}
event_processor_->SendAsync(events::IdentifyEventParams{
std::chrono::system_clock::now(), std::move(context)});

Expand Down Expand Up @@ -248,8 +323,8 @@
}

template <typename T>
EvaluationDetail<T> ClientImpl::VariationInternal(

Check warning on line 326 in libs/client-sdk/src/client_impl.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

libs/client-sdk/src/client_impl.cpp:326:33 [readability-function-cognitive-complexity]

function 'VariationInternal' has cognitive complexity of 28 (threshold 25)
FlagKey const& key,

Check warning on line 327 in libs/client-sdk/src/client_impl.cpp

View workflow job for this annotation

GitHub Actions / cpp-linter

libs/client-sdk/src/client_impl.cpp:327:5 [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'VariationInternal' of convertible types are easily swapped by mistake
Value default_value,
bool check_type,
bool detailed,
Expand Down
Loading
Loading