Repository navigation
Conversation
beekld
force-pushed
the
bklimt/SDK-3035/client-fdv2-identify
branch
from
October 3, 2026 01:21
d427e51 to
76a37e9
Compare
beekld
force-pushed
the
bklimt/SDK-3035/client-fdv2-identify
branch
from
October 5, 2026 18:00
76a37e9 to
a268f20
Compare
Base automatically changed from
bklimt/SDK-3033/client-fdv2-cache-initializer
to
main
October 5, 2026 23:25
beekld
force-pushed
the
bklimt/SDK-3035/client-fdv2-identify
branch
2 times, most recently
from
October 6, 2026 05:04
455610f to
4993c9f
Compare
beekld
force-pushed
the
bklimt/SDK-3035/client-fdv2-identify
branch
2 times, most recently
from
November 17, 2026 20:12
12dd3cb to
ce1105e
Compare
beekld
marked this pull request as ready for review
November 17, 2026 20:34
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: Identify-time FDv2 selector clearing in client_impl.cpp is a client SDK behavior change without an identify-path test in this PR; added tests cover cache and persistence only.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Human review is needed and no reviewers were assigned.
Sent by Cursor Approval Agent: Dry-Run PR Approver
beekld
force-pushed
the
bklimt/SDK-3035/client-fdv2-identify
branch
from
November 18, 2026 00:16
ce1105e to
2597cf9
Compare
kinyoklion
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Discards the FDv2 selector on a context change, so a selector earned for one context is never reused for another.
ClientImpldoesn't run an FDv2 data source until feat: Expose FDv2 through the client SDK configuration #624, so the identify test is in that PR.Note
Overview
On context change via
IdentifyAsync, the client now clears the in-memory FDv2 selector after the old data source shuts down and before the new one starts, so a selector tied to the previous context is never reused.RestartDataSourceandStartAsyncInternaltake aclear_selectorflag: identify passestrue; ordinaryStartAsyncpassesfalse.FlagManager::ClearSelectorforwards toFlagStore::ClearSelector, which drops only the selector and leaves cached flag values in place.New tests cover per-context cache reads in
FDv2CacheInitializerandLoadCachedbehavior on cache miss (retain in-memory data) vs hit (replace with persisted data).Reviewed by Cursor Bugbot for commit 2597cf9. Bugbot is set up for automated code reviews on this repo. Configure here.