refactor: replace spdlog with Poco::Logger, drop nlohmann_json#498
Merged
Conversation
lanthora
commented
Jul 8, 2026
lanthora
commented
Owner
- Remove unused CANDY_STATIC_NLOHMANN_JSON CMake variable
- Replace spdlog with Poco::Logger (Poco::Foundation already a dependency)
- Add candy/src/utils/log.h providing candy::logger() wrapper
- Add candy/src/utils/hex.h providing to_hex() replacement
- Update CMakeLists and Dockerfile to drop spdlog dependency
- Fix --websocket required() conflict with --config usage
- Fix missing transitive includes (unordered_map, thread)
- Remove unused CANDY_STATIC_NLOHMANN_JSON CMake variable - Replace spdlog with Poco::Logger (Poco::Foundation already a dependency) - Add candy/src/utils/log.h providing candy::logger() wrapper - Add candy/src/utils/hex.h providing to_hex() replacement - Update CMakeLists and Dockerfile to drop spdlog dependency - Fix --websocket required() conflict with --config usage - Fix missing transitive includes (unordered_map, thread)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.