sesame2spiner refactor#641
Open
adamdempsey90 wants to merge 11 commits into
Open
Conversation
…es. Modify cmake so that we build a library.
Collaborator
Author
|
Evidently there's some cmake stuff left to figure it when things like spiner are not requested or when not in submodule mode maybe |
13 tasks
adamdempsey90
commented
Jun 5, 2026
adamdempsey90
commented
Jun 5, 2026
adamdempsey90
commented
Jun 5, 2026
Co-authored-by: Adam M. Dempsey <adamdemps@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This does some refactoring on the code base to build
sesame2spineras a library thatsingularity-eoslinks in while maintaining the executablesesame2spiner.sesame2spinerwas linking insingularity-eosfor some things, so I have moved those shared headers into a new library calledsingularity-utils. For backwards compatibility in downstream codes, I have replaced the headers lost insingularity-eos/basewith forwarding headers tosingularity-utils. I have updated the includes insingularity-eosproper with the new ones.If I did everything correctly, nothing should've changed. So my plan is to have this MR merged, then follow up with adding the functions to
sesame2spinerthe library to process tables without reading a file.PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: