Skip to content

bump agent-skill-plugin plugin to version 1.0.1 - #2848

Open
xun404 wants to merge 4 commits into
langgenius:mainfrom
xun404:bump-agent-skill-plugin-plugin-1.0.1
Open

bump agent-skill-plugin plugin to version 1.0.1#2848
xun404 wants to merge 4 commits into
langgenius:mainfrom
xun404:bump-agent-skill-plugin-plugin-1.0.1

Conversation

@xun404

@xun404 xun404 commented Aug 9, 2026

Copy link
Copy Markdown

bump agent-skill-plugin plugin package to version 1.0.1

Plugin information

Submission type

  • Version update

What changed

  • Updated plugin package file
  • No breaking changes

Local validation

  • Dependencies install in a clean Python 3.12 environment
  • Plugin packaging passes the Dify CLI package check
  • Import and unit tests pass locally

Risk level

  • High risk

Security and privacy notes

The plugin is an agent strategy: it runs user queries through a configurable LLM and may invoke user-configured tools (including code execution, file operations, or arbitrary URL fetching) based on LLM decisions. See PRIVACY.md in the package.
Input constraints and security boundaries: the plugin itself does not execute code or make network requests; any tool invocations (including code execution, file operations, and URL fetching) happen only through Dify's standard tool permission checks and are only performed against user-configured tool credentials. The plugin does not store or transmit user data to any external service.

@github-actions github-actions Bot added the risk: high High-risk Marketplace submission label Aug 9, 2026

@crazywoola crazywoola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
Dependency install ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/.venv/bin/pip install -r /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/unpacked_plugin/requirements.txt error: subprocess-exited-with-e… Ensure requirements.txt installs successfully in a clean environment.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.9.0, but it was not found. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/.venv/bin/python /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/toolkit/validator/test-plugin-install.py -d /var/folders/c5/ssq8b54n0rj6… Fix the plugin so test-plugin-install.py passes.

Full Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=491, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 1.0.1 is available. None.
README language ✅ Pass README.md CJK ratio=0.0% (zh=0, en=2373, allowed_zh<=0) None.
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/.venv/bin/pip install -r /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/unpacked_plugin/requirements.txt error: subprocess-exited-with-e… Ensure requirements.txt installs successfully in a clean environment.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.9.0, but it was not found. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/.venv/bin/python /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-8vfz0d0x/toolkit/validator/test-plugin-install.py -d /var/folders/c5/ssq8b54n0rj6… Fix the plugin so test-plugin-install.py passes.
Packaging test ✅ Pass packaging check passed. None.

Next steps

  • Dependency install: Ensure requirements.txt installs successfully in a clean environment.
  • dify_plugin version: Use dify_plugin >= 0.9.0 in the packaged plugin environment.
  • Install test: Fix the plugin so test-plugin-install.py passes.

Please address these issues and push an update.

@crazywoola crazywoola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
dify_plugin version ❌ Fail dify_plugin version must be >= 0.9.0; found 0.7.1. Use dify_plugin >= 0.9.0 in the packaged plugin environment.

Full Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=491, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 1.0.1 is available. None.
README language ✅ Pass README.md CJK ratio=0.0% (zh=0, en=2373, allowed_zh<=0) None.
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements installed successfully. None.
dify_plugin version ❌ Fail dify_plugin version must be >= 0.9.0; found 0.7.1. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ✅ Pass plugin install test passed. None.
Packaging test ✅ Pass packaging check passed. None.

Next steps

  • dify_plugin version: Use dify_plugin >= 0.9.0 in the packaged plugin environment.

Please address these issues and push an update.

@xun404
xun404 force-pushed the bump-agent-skill-plugin-plugin-1.0.1 branch from a6969f4 to 957dad6 Compare August 10, 2026 08:59
@xun404
xun404 requested a review from crazywoola August 10, 2026 09:02
@crazywoola
crazywoola dismissed stale reviews from themself August 10, 2026 09:56

Superseded by a fresh full review of all open PRs on 2026-08-10.

crazywoola
crazywoola previously approved these changes Aug 10, 2026

@crazywoola crazywoola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Decision: Approve

Local Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=491, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 1.0.1 is available. None.
README language ✅ Pass README.md CJK ratio=0.0% (zh=0, en=2373, allowed_zh<=0) None.
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements installed successfully. None.
dify_plugin version ✅ Pass dify_plugin version 0.10.1 satisfies >= 0.9.0. None.
Install test ✅ Pass plugin install test passed. None.
Packaging test ✅ Pass packaging check passed. None.

@crazywoola

Copy link
Copy Markdown
Member

Hi @xun404 — thanks for the update! The latest package passes the full local review and is approved. The required pre-check-plugin check is still red, so we cannot merge it yet. Please re-run the failed workflow or push a small follow-up to trigger CI again. Once it is green, this should be ready to merge. 🙏

Copy link
Copy Markdown
Member

Hi @xun404 — here is the current CI summary for commit 957dad6.

❌ Blocking errors

  • manifest.yaml is missing the required repo and contact fields.
  • The PR template is missing the Plugin information → Contact field.
  • The PR body is missing the “Local validation” section.

⚠️ Warnings / review items

  • Add the recommended meta.minimum_dify_version field.
  • State whether the version update contains breaking changes in “What changed” or “Reviewer notes.”
  • Because this is marked high risk, describe input constraints, security boundaries, or dangerous-operation limits in “Security and privacy notes.”
  • pyyaml>=6.0 and pydantic>=2.0 have lower-bound-only constraints.
  • Workflow infrastructure warning (not caused by this PR): checkout/setup-python still target deprecated Node.js 20 and are being forced onto Node.js 24.

Open the failed pre-check-plugin job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: high High-risk Marketplace submission

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants