Skip to content

Add define_archiver plugin - #2836

Open
schnee-and-tetra wants to merge 4 commits into
langgenius:mainfrom
schnee-and-tetra:add-define_archiver-0.0.1
Open

Add define_archiver plugin#2836
schnee-and-tetra wants to merge 4 commits into
langgenius:mainfrom
schnee-and-tetra:add-define_archiver-0.0.1

Conversation

@schnee-and-tetra

@schnee-and-tetra schnee-and-tetra commented Aug 7, 2026

Copy link
Copy Markdown

Plugin Submission

  • Plugin: define_archiver
  • Version: 0.0.1
  • Author: schnee-and-tetra

Risk Level

  • Low risk
  • Medium risk
  • High risk

Automated submission by GitHub Actions.

@github-actions github-actions Bot added the risk: missing Missing or invalid Marketplace risk selection label Aug 7, 2026
@schnee-and-tetra
schnee-and-tetra force-pushed the add-define_archiver-0.0.1 branch from ec0f0a5 to a1ad0f2 Compare August 7, 2026 16:00
@github-actions github-actions Bot added risk: low Low-risk Marketplace submission and removed risk: missing Missing or invalid Marketplace risk selection labels Aug 7, 2026
@schnee-and-tetra
schnee-and-tetra force-pushed the add-define_archiver-0.0.1 branch 2 times, most recently from 2e245c4 to 6f5e873 Compare August 7, 2026 17:02

@crazywoola crazywoola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
README language ❌ Fail README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
Dependency install ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/pip install -r /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/unpacked_plugin/requirements.txt error: subprocess-exited-with-e… Ensure requirements.txt installs successfully in a clean environment.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.9.0, but it was not found. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/python /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/toolkit/validator/test-plugin-install.py -d /var/folders/c5/ssq8b54n0rj6… Fix the plugin so test-plugin-install.py passes.

Full Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=155, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.0.1 is available. None.
README language ❌ Fail README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/pip install -r /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/unpacked_plugin/requirements.txt error: subprocess-exited-with-e… Ensure requirements.txt installs successfully in a clean environment.
dify_plugin version ❌ Fail dify_plugin must be installed and >= 0.9.0, but it was not found. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ❌ Fail Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/python /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/toolkit/validator/test-plugin-install.py -d /var/folders/c5/ssq8b54n0rj6… Fix the plugin so test-plugin-install.py passes.
Packaging test ✅ Pass packaging check passed. None.

Next steps

Please address these issues and push an update.

@crazywoola crazywoola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Request Changes

Decision: Request changes

Failed Checks

Check Status Detail Required action
README language ❌ Fail README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
dify_plugin version ❌ Fail dify_plugin version must be >= 0.9.0; found 0.8.0. Use dify_plugin >= 0.9.0 in the packaged plugin environment.

Full Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=155, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.0.1 is available. None.
README language ❌ Fail README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements installed successfully. None.
dify_plugin version ❌ Fail dify_plugin version must be >= 0.9.0; found 0.8.0. Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Install test ✅ Pass plugin install test passed. None.
Packaging test ✅ Pass packaging check passed. None.

Next steps

Please address these issues and push an update.

@schnee-and-tetra
schnee-and-tetra force-pushed the add-define_archiver-0.0.1 branch 2 times, most recently from b132fc5 to ac814da Compare August 10, 2026 08:46
@crazywoola
crazywoola dismissed stale reviews from themself August 10, 2026 09:56

Superseded by a fresh full review of all open PRs on 2026-08-10.

crazywoola
crazywoola previously approved these changes Aug 10, 2026

@crazywoola crazywoola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

Decision: Approve

Local Check Results

Check Status Detail Required action
PR content language ✅ Pass PR title/body CJK ratio=0.0% (zh=0, en=155, ignored_zh=0, allowed_zh<=0) None.
Project structure ✅ Pass All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. None.
Manifest author ✅ Pass author is valid. None.
Icon validation ✅ Pass icon exists: _assets/icon.svg None.
Version check ✅ Pass version 0.0.1 is available. None.
README language ✅ Pass README.md CJK ratio=0.0% (zh=0, en=6751, allowed_zh<=0) None.
PRIVACY.md ✅ Pass PRIVACY.md exists and is non-empty. None.
Dependency install ✅ Pass requirements installed successfully. None.
dify_plugin version ✅ Pass dify_plugin version 0.10.2 satisfies >= 0.9.0. None.
Install test ✅ Pass plugin install test passed. None.
Packaging test ✅ Pass packaging check passed. None.

@crazywoola

Copy link
Copy Markdown
Member

Hi @schnee-and-tetra — thank you for the update! The latest package fixes the previous review findings, passes all local checks, and is approved. The required pre-check-plugin check is still red, so please re-run it or push a small follow-up to trigger CI again. Once CI is green, this should be ready to merge. 🙏

@schnee-and-tetra
schnee-and-tetra force-pushed the add-define_archiver-0.0.1 branch from ac814da to 80b820b Compare August 10, 2026 18:55
@schnee-and-tetra

Copy link
Copy Markdown
Author

@crazywoola Thank you for the approval! I have updated the branch, and the workflow is now awaiting your approval to run. Could you please approve and trigger the CI? 🙏

@schnee-and-tetra
schnee-and-tetra force-pushed the add-define_archiver-0.0.1 branch 3 times, most recently from 55c6aef to fb87ad0 Compare August 11, 2026 03:55
@schnee-and-tetra

Copy link
Copy Markdown
Author

Thank you! I’ve synced my fork with the latest upstream changes and updated the PR. The pre-check workflow is now awaiting maintainer approval again.

Could you please approve and run the workflow when convenient? I’d like to verify the pre-check against the latest upstream state.

Copy link
Copy Markdown
Member

Hi @schnee-and-tetra — here is the current CI summary for commit 6469fd8.

❌ Blocking errors

  • The PR body is missing the “Plugin information,” “Submission type,” “What changed,” and “Local validation” sections.
  • Because sensitive capabilities were detected, the PR body must also include “Security and privacy notes.”

⚠️ Warnings / review items

  • Rename localized README files to the expected README.<locale>.md form: README_zh-Hant.md, README_zh-Hans.md, and README_ja.md currently use underscores.
  • dify_plugin>=0.9.0 has a lower-bound-only constraint.
  • Disclose/review the filesystem operation at utils/logger.py:71 and network request at utils/urls.py:43.
  • The financial-activity scanner flagged checkout-related lines in .github/workflows/release.yml:14,15,50,51,74 as “payment processing.” These appear likely to be false positives, but they still need review.
  • Workflow infrastructure warning (not caused by this PR): checkout/setup-python still target deprecated Node.js 20 and are being forced onto Node.js 24.

Open the failed pre-check-plugin job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low Low-risk Marketplace submission

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants