Add define_archiver plugin - #2836
Conversation
ec0f0a5 to
a1ad0f2
Compare
2e245c4 to
6f5e873
Compare
crazywoola
left a comment
There was a problem hiding this comment.
❌ Request Changes
Decision: Request changes
Failed Checks
| Check | Status | Detail | Required action |
|---|---|---|---|
README language |
❌ Fail | README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme | Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme |
Dependency install |
❌ Fail | Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/pip install -r /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/unpacked_plugin/requirements.txt error: subprocess-exited-with-e… | Ensure requirements.txt installs successfully in a clean environment. |
dify_plugin version |
❌ Fail | dify_plugin must be installed and >= 0.9.0, but it was not found. | Use dify_plugin >= 0.9.0 in the packaged plugin environment. |
Install test |
❌ Fail | Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/python /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/toolkit/validator/test-plugin-install.py -d /var/folders/c5/ssq8b54n0rj6… | Fix the plugin so test-plugin-install.py passes. |
Full Check Results
| Check | Status | Detail | Required action |
|---|---|---|---|
PR content language |
✅ Pass | PR title/body CJK ratio=0.0% (zh=0, en=155, ignored_zh=0, allowed_zh<=0) | None. |
Project structure |
✅ Pass | All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. | None. |
Manifest author |
✅ Pass | author is valid. | None. |
Icon validation |
✅ Pass | icon exists: _assets/icon.svg | None. |
Version check |
✅ Pass | version 0.0.1 is available. | None. |
README language |
❌ Fail | README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme | Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme |
PRIVACY.md |
✅ Pass | PRIVACY.md exists and is non-empty. | None. |
Dependency install |
❌ Fail | Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/pip install -r /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/unpacked_plugin/requirements.txt error: subprocess-exited-with-e… | Ensure requirements.txt installs successfully in a clean environment. |
dify_plugin version |
❌ Fail | dify_plugin must be installed and >= 0.9.0, but it was not found. | Use dify_plugin >= 0.9.0 in the packaged plugin environment. |
Install test |
❌ Fail | Command failed (1): /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/.venv/bin/python /var/folders/c5/ssq8b54n0rj6rbmghy7_2xdm0000gn/T/pr-review-helper-etke8lp6/toolkit/validator/test-plugin-install.py -d /var/folders/c5/ssq8b54n0rj6… | Fix the plugin so test-plugin-install.py passes. |
Packaging test |
✅ Pass | packaging check passed. | None. |
Next steps
- README language: Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
- Dependency install: Ensure requirements.txt installs successfully in a clean environment.
- dify_plugin version: Use dify_plugin >= 0.9.0 in the packaged plugin environment.
- Install test: Fix the plugin so test-plugin-install.py passes.
Please address these issues and push an update.
crazywoola
left a comment
There was a problem hiding this comment.
❌ Request Changes
Decision: Request changes
Failed Checks
| Check | Status | Detail | Required action |
|---|---|---|---|
README language |
❌ Fail | README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme | Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme |
dify_plugin version |
❌ Fail | dify_plugin version must be >= 0.9.0; found 0.8.0. | Use dify_plugin >= 0.9.0 in the packaged plugin environment. |
Full Check Results
| Check | Status | Detail | Required action |
|---|---|---|---|
PR content language |
✅ Pass | PR title/body CJK ratio=0.0% (zh=0, en=155, ignored_zh=0, allowed_zh<=0) | None. |
Project structure |
✅ Pass | All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. | None. |
Manifest author |
✅ Pass | author is valid. | None. |
Icon validation |
✅ Pass | icon exists: _assets/icon.svg | None. |
Version check |
✅ Pass | version 0.0.1 is available. | None. |
README language |
❌ Fail | README.md CJK ratio=0.2% (zh=11, en=6796, allowed_zh<=0); Chinese characters are not allowed. Use multilingual README guidance: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme | Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme |
PRIVACY.md |
✅ Pass | PRIVACY.md exists and is non-empty. | None. |
Dependency install |
✅ Pass | requirements installed successfully. | None. |
dify_plugin version |
❌ Fail | dify_plugin version must be >= 0.9.0; found 0.8.0. | Use dify_plugin >= 0.9.0 in the packaged plugin environment. |
Install test |
✅ Pass | plugin install test passed. | None. |
Packaging test |
✅ Pass | packaging check passed. | None. |
Next steps
- README language: Remove Chinese characters from README.md and use the multilingual README pattern: https://docs.dify.ai/en/develop-plugin/features-and-specs/plugin-types/multilingual-readme#multilingual-readme
- dify_plugin version: Use dify_plugin >= 0.9.0 in the packaged plugin environment.
Please address these issues and push an update.
b132fc5 to
ac814da
Compare
Superseded by a fresh full review of all open PRs on 2026-08-10.
crazywoola
left a comment
There was a problem hiding this comment.
✅ LGTM
Decision: Approve
Local Check Results
| Check | Status | Detail | Required action |
|---|---|---|---|
PR content language |
✅ Pass | PR title/body CJK ratio=0.0% (zh=0, en=155, ignored_zh=0, allowed_zh<=0) | None. |
Project structure |
✅ Pass | All expected files present: manifest.yaml, README.md, PRIVACY.md. _assets/: yes. | None. |
Manifest author |
✅ Pass | author is valid. | None. |
Icon validation |
✅ Pass | icon exists: _assets/icon.svg | None. |
Version check |
✅ Pass | version 0.0.1 is available. | None. |
README language |
✅ Pass | README.md CJK ratio=0.0% (zh=0, en=6751, allowed_zh<=0) | None. |
PRIVACY.md |
✅ Pass | PRIVACY.md exists and is non-empty. | None. |
Dependency install |
✅ Pass | requirements installed successfully. | None. |
dify_plugin version |
✅ Pass | dify_plugin version 0.10.2 satisfies >= 0.9.0. | None. |
Install test |
✅ Pass | plugin install test passed. | None. |
Packaging test |
✅ Pass | packaging check passed. | None. |
|
Hi @schnee-and-tetra — thank you for the update! The latest package fixes the previous review findings, passes all local checks, and is approved. The required |
ac814da to
80b820b
Compare
|
@crazywoola Thank you for the approval! I have updated the branch, and the workflow is now awaiting your approval to run. Could you please approve and trigger the CI? 🙏 |
55c6aef to
fb87ad0
Compare
fb87ad0 to
6469fd8
Compare
|
Thank you! I’ve synced my fork with the latest upstream changes and updated the PR. The pre-check workflow is now awaiting maintainer approval again. Could you please approve and run the workflow when convenient? I’d like to verify the pre-check against the latest upstream state. |
|
Hi @schnee-and-tetra — here is the current CI summary for commit ❌ Blocking errors
|
Plugin Submission
Risk Level
Automated submission by GitHub Actions.