feat(api): update API spec from langfuse/langfuse 6a4314a - #1820
feat(api): update API spec from langfuse/langfuse 6a4314a#1820langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
LGTM — auto-generated API client update from the Fern spec, purely additive and mechanical.
What was reviewed: the new session_id parameter on observations.get_many is wired through consistently in both sync/async client.py and raw_client.py (added to the params dict as sessionId, matching the existing pattern for user_id/userId). The boolean filter operator and isRootObservation docs additions on the unstable evaluation-rule filter types are documentation-only (the EvaluationRuleFilter_Boolean model already existed). The removed "deprecated" docstring blocks on scores.get_many/get_by_id and the reworded blob-storage/SCIM/comments docstrings are text-only changes with no code impact.
Extended reasoning...
Overview
This PR regenerates the Fern-based API client from an updated OpenAPI spec (langfuse/langfuse @ 6a4314a). All 16 changed files are auto-generated client/type files. The changes are: (1) docstring/description rewording for blob storage export source defaults, comment author constraints, and SCIM password field; (2) new documented isRootObservation dimension/filter examples for the metrics client (docs only, no new code path); (3) a new optional session_id parameter added to observations.get_many in both sync/async client and raw_client, forwarded as sessionId query param, following the exact existing pattern; (4) removal of stale "deprecated" docstring notices on two scores client methods; (5) documentation of the pre-existing boolean filter operator/isRootObservation column for the unstable evaluation-rule filter types (no new Pydantic model — EvaluationRuleFilter_Boolean already existed).
Security risks
None. No auth, crypto, or permission logic is touched. All changes are either docstrings or a new pass-through optional query parameter on a GET endpoint.
Level of scrutiny
Low. This is a generated-client update mirroring an upstream spec change, mechanically following established patterns (identical to how user_id/trace_id/etc. are already wired). No hand-written business logic, no control-flow changes.
Other factors
No CODEOWNERS-restricted paths are involved (these are auto-generated API client files, consistent with prior spec-sync PRs in this repo). The bug-hunting pass found nothing, and my own read of the diff found the new parameter correctly threaded through both the sync and async code paths.
Greptile Summary
Updates the generated API client from the latest upstream specification.
Confidence Score: 5/5
The PR appears safe to merge, with no concrete changed-code failure identified.
The only runtime change consistently wires an optional session filter through keyword-only public and raw clients, while the remaining changes update generated documentation without introducing a demonstrated contract or validation failure.
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile
Context used: