Add DC offset correction to desktop audio#11
Open
lxpollitt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent of #6 DC-offset audio fix for web, but for desktop. (Note that on desktop the symptom shows up slightly differently from web. Silence at emulator session start is fine, but once non-silent audio has played and left the chip with non-zero volume registers, the bias produces audible periodic clicks and a click on every mute/unmute. Same root cause as #6: the chip's unipolar signal carries a DC offset that the current conversion to signed 16-bit PCM didn't remove.)