fix(encoding): read wrapped miniblock level counts - #8410
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(encoding): read wrapped miniblock level counts#8410lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
u16wrap, while preserving strict corruption checksRoot cause
Pylance 6.0.1 cast a miniblock's structural level count to
u16. For list pages with a dense prefix and many trailing empty lists, the header wrapped while the RLE payload retained every level. Readers trusted the truncated count and either short-read the list column or rejected the complete payload as an RLE overflow. Current writers already prevent these oversized miniblock chunks; this change restores stable-format read compatibility for files already written.Validation
cargo test -p lance-encoding miniblock_levels --libcargo test -p lance-encoding block_rle_infers_value_count_from_run_lengths --libcargo test -p lance test_v6_0_1_miniblock_level_count_overflow --libcargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsmake buildfrompython/uv run make lintfrompython/Fixes #6936