fix(datafusion): use caller session for filter planning - #8407
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(datafusion): use caller session for filter planning#8407lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Forwarding the originating DataFusion session when physicalizing Lance filters fixes the demonstrated FFI UDF/configuration failure while preserving the default Dataset scanner path. Using the session directly is preferable to copying selected registry or configuration fields because it retains the complete caller planning contract.
Please mark this PR with the breaking-change label.
Contributor
Author
|
No code change was needed; the requested |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Lance discarded the Session supplied to TableProvider::scan and rebuilt physical filter expressions with its default planner. Across FFI, that lost the caller-owned UDF and session configuration, so pushed-down custom UDF filters failed during planning or execution.
Validation
Fixes #5144