fix(storage): report AWS credential failures as I/O - #8406
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(storage): report AWS credential failures as I/O#8406lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change corrects the error category at the AWS credential-adapter boundary while preserving the provider diagnostic. The injected-provider regression test covers the propagated object-store error and confirms it no longer presents an external credential failure as an internal Lance defect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
AwsCredentialAdapterclassified failures from the external AWS credential provider chain as Lance internal errors. In managed environments such as AWS Glue, a missing or unreachable credential source therefore produced the misleading internal-bug wrapper shown in the issue instead of an actionable I/O/configuration-path failure.Fix
Validation
cargo fmt --allcargo clippy --all --tests --benches -- -D warningscargo test -p lance-io test_aws_credential_failure_is_io_errorcargo test -p lance-io -- --skip uring::tests(197 unit tests and doctests passed)A full
cargo test -p lance-iowas also attempted; unrelated Linuxio_uringcases failed or hung in this container, so the passing package run excluded that module.Fixes #2466