fix: filter stale physical row ids in take - #8401
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
This closes the legacy TakeExec parity gap: physical row IDs are checked against the current deletion mask before carried columns and fetched data are merged, matching the existing stable-ID and modern live-view behavior. Deleted and removed-fragment hits now drop while surviving IDs, scores, and fetched values remain aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
TakeExec::get_row_addrs only built a validity mask when stable row IDs were enabled. With default physical row IDs, stale index entries were passed through unchanged. Fragment reads omit deleted rows, so the taken columns could contain fewer rows than the upstream FTS batch and merge_with_schema failed with unequal RecordBatch lengths.
Validation
Fixes #7508