fix: allow empty V1 writes with non-nullable columns - #8394
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix: allow empty V1 writes with non-nullable columns#8394lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change fixes the V1 empty-batch panic at the statistics-schema boundary: min/max bounds may be absent even when the data column is non-nullable. Keeping those bounds nullable uses the existing V1 statistics grammar and preserves one statistics row per data batch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The V1 statistics collector copied source-column nullability onto its
min_valueandmax_valuefields. Empty string pages legitimately have no bounds, so Arrow rejected their null statistics values while constructing the non-nullable stats struct.Scope
This removes the panic when creating an empty V1 table. IVF_PQ index creation still requires vectors for centroid training and will continue to reject an empty dataset.
Validation
cargo fmt --all -- --checkcargo test -p lance-file(153 unit tests and 4 doctests)cargo clippy --all --tests --benches -- -D warningsFixes #1914