fix(index): correct cosine RabitQ query factor - #8393
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
fix(index): correct cosine RabitQ query factor#8393lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The residual-query estimator now uses the squared-L2 partition factor required by normalized cosine vectors while preserving the distinct dot-product offset. This is the narrow fix for the incorrect legacy score and bound semantics, and the focused regression covers the affected calculator path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Cosine vectors are normalized before IVF_RQ search, so the residual-query estimator operates on squared L2 distances. Its query-factor match still grouped Cosine with Dot and subtracted
1.0, shifting every approximate cosine distance.Validation
cargo test -p lance-index test_residual_query_cosine_uses_l2_query_factorcargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsFixes #5649