test: cover SharedStream waiting waker replacement - #8392
Open
lance-gatefixer[bot] wants to merge 1 commit into
Open
test: cover SharedStream waiting waker replacement#8392lance-gatefixer[bot] wants to merge 1 commit into
lance-gatefixer[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedStreamRoot cause and repair
A consumer may be polled more than once while the other half owns polling of the inner stream. The original implementation asserted that no waiting waker was already stored, but repeated or spurious polls are valid and triggered the panic reported in #2391. Current
mainalready contains the production correction from #3079, which replaces the stale waker; this PR adds the missing deterministic regression test that fails with the original assertion.Validation
cargo test -p lance-corecargo fmt --allcargo clippy --all --tests --benches -- -D warningsFixes #2391