test: cover filtered legacy scans with stable row ids - #8391
Open
lance-gatefixer[bot] wants to merge 2 commits into
Open
test: cover filtered legacy scans with stable row ids#8391lance-gatefixer[bot] wants to merge 2 commits into
lance-gatefixer[bot] wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
This focused regression test covers the reported legacy stable-row-ID scan failure without changing the frozen legacy reader. Its completeness and uniqueness assertions exercise the physical-selection contract across concurrent batch readahead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The historical legacy filtered-scan path sliced the stable row-ID sequence by output-batch offset instead of the physical selection in
ReadBatchParams, allowing filtered pages to reuse IDs. The current reader uses the physical selection correctly; this regression test protects that behavior without extending the frozen legacy format.Validation
cargo test -p lance test_filter_legacy_dataset_with_stable_row_idscargo fmt --allcargo clippy --all --tests --benches -- -D warningsFixes #3507