chore: raise fastapi to 0.141.1 and move tests to httpx2 - #82
Merged
Conversation
fastapi 0.104.1 brought starlette 0.27, whose TestClient passed both app= and transport= to httpx.Client. The app= argument is redundant and httpx deprecated it, so every test run printed a warning and the test job had to pin httpx below 0.28, the release that removed the argument. Current starlette asks for httpx2 instead of httpx and warns when it finds the older package, so the test dependency moves with it. backend/pyproject.toml carried its own fastapi pin and is raised to match, so pip install . and the container image agree. All seven lancedb versions pass, 33 tests each, no warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises fastapi from 0.104.1 to 0.141.1 and moves the test dependency from httpx to httpx2.
fastapi 0.104.1 brought starlette 0.27.0. Its
TestClientpassed bothapp=andtransport=tohttpx.Client. Theapp=argument is redundant, because the transport already wraps the application, and httpx deprecated it. Every test run printed a warning, and the test job had to pinhttpx<0.28, the release that removed the argument.Current starlette asks for
httpx2rather thanhttpx, and warns on every run when it finds the older package. The test dependency moves with it, in the workflow and in the README.backend/pyproject.tomlcarried its ownfastapi==0.104.1pin, separate frombackend/requirements.txt. It is raised to match, sopip install .and the container image agree.Tested against all seven lancedb versions in the matrix: 33 tests pass on each, with no warnings.
Fixes #81