Update deprecated API usage - #76
Merged
Merged
Conversation
Collaborator
|
Thanks for the fix. The lifespan handler is the correct replacement. The test suite covers it already, because I ran the full version matrix against your branch. All 30 tests pass on the seven lancedb versions, 0.3.1 to 0.33.0. The warning count drops from 3 to 1. The last warning is the You do not need to change anything in this PR. This project wants a changelog entry for every PR. I will write that entry and open the issue for it. You have three other PRs open here already. |
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During local testing, I found certain APIs have been deprecated.
/Users/haojiang/Desktop/lance-data-viewer/backend/app.py:38: DeprecationWarning: on_event is deprecated, use lifespan event handlers instead.