Repository navigation
Size mismatch feedback - #19
Merged
Merged
Conversation
Check the response shape against the answer before grading. Mismatches (too many/few entries, wrong nesting) now return is_correct False with feedback describing the difference, rather than raising an exception or an IndexError. Also fixes short responses being graded on a subset of the answer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Mock the symbolicEqual client at import so the tests run without AWS credentials, and check mismatches are reported without grading cells. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Patch the client per test instead, so the tests work whether or not credentials are present and never replace a real client module-wide. Note in the readme that the healthcheck doesn't run evaluation_test.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test size feedback through evaluation_function only, and remove the now-redundant shape_test.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Tested against 500 database entries: https://github.com/lambda-feedback/ArraySymbolicEqual/actions/runs/41445216519 One error, which is the same as main. |
m-messer
requested changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks the size of the response before checking the content.
Needs significant testing before deploying to PROD