Fix link on Fuchsia#126
Merged
Merged
Conversation
Fuchsia requires `__errno_location` as well. This change adds the missing constant.
bherrera
pushed a commit
to misttech/fuchsia
that referenced
this pull request
Jun 26, 2026
This moves errno to forks/ in the process due to a link error in the unmodified upstream release. A pull request for upstream has been created at lambda-fairy/rust-errno#126. It also includes a change in action_tracer.py for a semantic change in tempfile, namely that relative paths are resolved to absolute paths now, which would appear to action_tracer.py as if the build was no longer hermetic. Fixed: 523181583 Change-Id: I233c36f8e031ca4d99a8dec5efa948459f5565d2 Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1662676 Reviewed-by: David Koloski <dkoloski@google.com> Fuchsia-Auto-Submit: Thomas Zander <thomasalpinus@google.com> Reviewed-by: Eric Stone <ecstone@google.com> Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com> Reviewed-by: James Sullivan <jfsulliv@google.com> SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Thomas Zander <thomasalpinus@google.com> Reviewed-by: Gary Bressler <geb@google.com> Reviewed-by: Aidan Wolter <awolter@google.com> Reviewed-by: Steven Grady <slgrady@google.com> Reviewed-by: Aaron Wood <aaronwood@google.com>
bherrera
pushed a commit
to misttech/fuchsia
that referenced
this pull request
Jun 26, 2026
This reverts commit 2ddd637. Reason for revert: broke consistency builder Failure Link: https://luci-milo.appspot.com/ui/p/turquoise/builders/global.ci/core.x64-asan-bazel_consistency/b8678193683418213889/overview Original change's description: > [rust-3p] Update tempfile to 3.27.0 > > This moves errno to forks/ in the process due to a link error in the > unmodified upstream release. A pull request for upstream has > been created at lambda-fairy/rust-errno#126. > > It also includes a change in action_tracer.py for a semantic change in > tempfile, namely that relative paths are resolved to absolute paths now, > which would appear to action_tracer.py as if the build was no longer > hermetic. > > Fixed: 523181583 > Change-Id: I233c36f8e031ca4d99a8dec5efa948459f5565d2 > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1662676 > Reviewed-by: David Koloski <dkoloski@google.com> > Fuchsia-Auto-Submit: Thomas Zander <thomasalpinus@google.com> > Reviewed-by: Eric Stone <ecstone@google.com> > Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com> > Reviewed-by: James Sullivan <jfsulliv@google.com> > SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> > Commit-Queue: Thomas Zander <thomasalpinus@google.com> > Reviewed-by: Gary Bressler <geb@google.com> > Reviewed-by: Aidan Wolter <awolter@google.com> > Reviewed-by: Steven Grady <slgrady@google.com> > Reviewed-by: Aaron Wood <aaronwood@google.com> Bug: 523181583 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id768996002e5a72367b91e7702c4fee3560b966c Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1674994 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Commit-Queue: Marie Janssen <jamuraa@google.com> Exempt: android-build-ayeaye@system.gserviceaccount.com <android-build-ayeaye@system.gserviceaccount.com>
bherrera
pushed a commit
to misttech/fuchsia
that referenced
this pull request
Jun 26, 2026
This is a reland of commit 2ddd637 It fixes the observed build breakage and squashes in the fix from https://fxrev.dev/1674236 Original change's description: > [rust-3p] Update tempfile to 3.27.0 > > This moves errno to forks/ in the process due to a link error in the > unmodified upstream release. A pull request for upstream has > been created at lambda-fairy/rust-errno#126. > > It also includes a change in action_tracer.py for a semantic change in > tempfile, namely that relative paths are resolved to absolute paths now, > which would appear to action_tracer.py as if the build was no longer > hermetic. > > Fixed: 523181583 > Change-Id: I233c36f8e031ca4d99a8dec5efa948459f5565d2 > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1662676 > Reviewed-by: David Koloski <dkoloski@google.com> > Fuchsia-Auto-Submit: Thomas Zander <thomasalpinus@google.com> > Reviewed-by: Eric Stone <ecstone@google.com> > Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com> > Reviewed-by: James Sullivan <jfsulliv@google.com> > SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> > Commit-Queue: Thomas Zander <thomasalpinus@google.com> > Reviewed-by: Gary Bressler <geb@google.com> > Reviewed-by: Aidan Wolter <awolter@google.com> > Reviewed-by: Steven Grady <slgrady@google.com> > Reviewed-by: Aaron Wood <aaronwood@google.com> Fixed: 523181583 Change-Id: I85bde842ccfe7c26bb260db8a8cc333d213a932c Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1677255 SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com> Reviewed-by: David Koloski <dkoloski@google.com> Reviewed-by: Clayton Wilkinson <wilkinsonclay@google.com> Commit-Queue: Thomas Zander <thomasalpinus@google.com> Reviewed-by: Aaron Wood <aaronwood@google.com> Reviewed-by: James Sullivan <jfsulliv@google.com> Reviewed-by: Steven Grady <slgrady@google.com> Reviewed-by: Eric Stone <ecstone@google.com> Reviewed-by: Aidan Wolter <awolter@google.com> Reviewed-by: Gary Bressler <geb@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuchsia requires
__errno_locationas well. This change adds the missing constant.