Skip to content

fix(proxy): align discovery container name - #127

Merged
vishr merged 2 commits into
mainfrom
security/socketless-proxy
Aug 27, 2026
Merged

fix(proxy): align discovery container name#127
vishr merged 2 commits into
mainfrom
security/socketless-proxy

Conversation

@vishr

@vishr vishr commented Aug 27, 2026

Copy link
Copy Markdown
Member

What this changes

  • Rename the managed discovery container from onebox-proxy-discovery to onebox-discovery, matching the published image name.
  • Keep backward-compatible teardown cleanup for the legacy name.
  • Require exact container name plus the generated Compose project and service labels before any fallback force-removal, protecting unrelated same-named containers.
  • Update Compose rendering and teardown ownership tests for current and legacy names.

Verification

  • just check passes locally: module tidiness, formatting, vet, all Go tests, generated documentation verification, and the static site build.
  • CLI-derived docs were regenerated; all 16 generated pages and the published artifact remain current with no diff.
  • The manual docs/site contain no stale legacy container-name references.
  • Astro reports zero errors, warnings, or hints.
  • All five CI jobs pass, including Docker end-to-end and native CLI smoke tests on Linux, macOS, and Windows.
  • The branch is based on current main, conflict-free, and mergeable.

Context

The original socketless discovery work is already on main through security-fork commit d6a79ab. This PR contains the focused container-name follow-up and its ownership-safe migration cleanup.

@vishr vishr added bug Something isn't working priority: high High-impact work to address before routine backlog items labels Aug 27, 2026
@vishr
vishr force-pushed the security/socketless-proxy branch from 5723f54 to bf5f23e Compare August 27, 2026 15:06
Match the running container name to the published image while removing legacy onebox-proxy-discovery instances during teardown.
@vishr
vishr force-pushed the security/socketless-proxy branch from 442176f to f5d676e Compare August 27, 2026 15:32
@vishr vishr changed the title fix(proxy): isolate Docker discovery fix(proxy): align discovery container name Aug 27, 2026
Exact container names can be reused by unrelated workloads. Require generated Compose project and service labels before force-removing fallback matches.
@vishr
vishr merged commit 063c739 into main Aug 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: high High-impact work to address before routine backlog items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant