Repository navigation
feat: record accepted rows in every resource sample - #6
Merged
Merged
Conversation
Each sample now carries ingest_rows_total, Fanout's cumulative accepted rows by signal from fanout_ingest_rows_total. Consumers can derive per-second ingest rates from consecutive samples, for example to replay the sustained phase second by second. The field is omitted when the metric is absent, and headline tables and gates are unchanged. Claude-Session: https://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each
samples.jsonlentry now carriesingest_rows_total, Fanout's cumulative accepted rows by signal fromfanout_ingest_rows_total. Consumers can derive per-second ingest rates from consecutive samples, for example to replay the sustained phase second by second. The field is omitted when the metric is absent; headline tables and gates are unchanged.Test plan
go test ./...andgo vet ./..., with fixtures for the series present and absenthttps://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW