Repository navigation
feat: record Fanout's background work in resource samples - #4
Merged
Merged
Conversation
A benchmark run could show Fanout slowing down without showing why: samples recorded CPU, memory, queue depth and Parquet files, but nothing about rollups, write gates, backpressure or compaction. Each sample now also carries cumulative rollup durations by component, write-gate hold and wait time by operation, compaction time and count, Parquet publish wait, ingest backpressure time and the compaction backlog gauge. Fields are omitted when a Fanout release does not export them, and the report's headline tables and gates are unchanged. Claude-Session: https://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark runs could show Fanout slowing down without showing why. Each
samples.jsonlentry now also records, from Fanout's/metrics:Fields are omitted when a Fanout release does not export them. Headline tables and gates are unchanged.
Test plan
go test ./...andgo vet ./..., including metric fixtures with the series present and absenthttps://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW