Fix undefined echo.Map in homepage Hello World example - #435
Merged
aldas merged 1 commit intoAug 17, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The homepage Hello World example (
site/src/components/HomeHero.astro) usedecho.Map{"message": "Hello, World!"}, butecho.Mapdoes not exist as a type in Echo v5. Copying the homepage example as-is fails to compile.This replaces it with a plain
map[string]string{"message": "Hello, World!"}, matching the pattern already used in the v5 Quickstart docs.Why this PR targets echox instead of echo
The issue was filed on
labstack/echo(labstack/echo#3065) because that's the natural place to report a docs/website bug, but the homepage/website source actually lives in this repo (labstack/echox). This PR fixes the bug where the code actually lives.Fixes labstack/echo#3065
Test plan
npm ci && npx astro buildinsite/completes successfully with no errorsecho.Mapno longer appears anywhere in the built outputContext.JSON(code int, i any)signature acceptsmap[string]string, so the example now compiles as advertised