Repository navigation
fix: commit response status before flushing - #3184
Draft
Plastic-time wants to merge 2 commits into
Draft
Plastic-time wants to merge 2 commits into
Plastic-time wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Flushing an Echo response before writing its body commits the underlying HTTP headers, but leaves Echo's
Committedflag false and skipsBeforecallbacks. A staged status such as 202 also becomes 200 on the wire. The delayed status writer has the same discrepancy.Commit the configured status (defaulting to 200) before delegating Flush in both writers. This makes subsequent writes observe the already committed response and runs Before hooks exactly once.
Validation
Go 1.27.3 on Windows:
go test -race ./...passed, including middleware and echotest.go vet ./...passed.go run honnef.co/go/tools/cmd/staticcheck@latest ./...passed.go run golang.org/x/lint/golint@latest -set_exit_status ./...passed.gofmtandgit diff --checkpassed.Tests also cover headers added by Before hooks, repeated Flush calls, and a body write after flushing. No new public API or dependencies.
AI assistance
Codex (GPT-6) assisted with investigation, implementation, tests, and this description. Submitted as a draft for human review.