fix(bind): restore []string values for map[string]interface{} duplicates#2982
Open
leno23 wants to merge 1 commit into
Open
fix(bind): restore []string values for map[string]interface{} duplicates#2982leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
When binding multipart/form-data to map[string]interface{}, store a single
value as string and multiple values as []string. This matches the behavior
before v4.13.0 and the intent of labstack#2656.
Fixes labstack#2731
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
map[string]interface{}stringand multiple values as[]stringProblem
Since v4.13.0, binding duplicate multipart fields like two
ima_slicevalues tomap[string]interface{}only kept the first value. Applications expecting a slice silently broke.This regressed after #2656, which intended to preserve pre-v4.12.0 single-string behavior but always bound
v[0].Fix
For
map[string]interface{}/map[string]any:string[]stringTest plan
TestDefaultBinder_bindDataToMapTestBindMultipartFormToMapInterfacego test ./... -run 'TestDefaultBinder_bindDataToMap|TestBindMultipartFormToMapInterface'Fixes #2731